Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1343)

Unified Diff: chrome/browser/ui/views/frame/browser_view_layout.cc

Issue 686463004: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view_layout.cc
diff --git a/chrome/browser/ui/views/frame/browser_view_layout.cc b/chrome/browser/ui/views/frame/browser_view_layout.cc
index 28c570d7f41fa2e5415dd65b68a68c4199b073a0..32a3d14327983914325904ad61250877a08b53c4 100644
--- a/chrome/browser/ui/views/frame/browser_view_layout.cc
+++ b/chrome/browser/ui/views/frame/browser_view_layout.cc
@@ -64,7 +64,7 @@ class BrowserViewLayout::WebContentsModalDialogHostViews
: browser_view_layout_(browser_view_layout) {
}
- virtual ~WebContentsModalDialogHostViews() {
+ ~WebContentsModalDialogHostViews() override {
FOR_EACH_OBSERVER(ModalDialogHostObserver,
observer_list_,
OnHostDestroying());
@@ -76,7 +76,7 @@ class BrowserViewLayout::WebContentsModalDialogHostViews
OnPositionRequiresUpdate());
}
- virtual gfx::Point GetDialogPosition(const gfx::Size& size) override {
+ gfx::Point GetDialogPosition(const gfx::Size& size) override {
views::View* view = browser_view_layout_->contents_container_;
gfx::Rect content_area = view->ConvertRectToWidget(view->GetLocalBounds());
const int middle_x = content_area.x() + content_area.width() / 2;
@@ -84,7 +84,7 @@ class BrowserViewLayout::WebContentsModalDialogHostViews
return gfx::Point(middle_x - size.width() / 2, top);
}
- virtual gfx::Size GetMaximumDialogSize() override {
+ gfx::Size GetMaximumDialogSize() override {
views::View* view = browser_view_layout_->contents_container_;
gfx::Rect content_area = view->ConvertRectToWidget(view->GetLocalBounds());
const int top = browser_view_layout_->web_contents_modal_dialog_top_y_;
@@ -92,17 +92,17 @@ class BrowserViewLayout::WebContentsModalDialogHostViews
}
private:
- virtual gfx::NativeView GetHostView() const override {
+ gfx::NativeView GetHostView() const override {
gfx::NativeWindow window =
browser_view_layout_->browser()->window()->GetNativeWindow();
return views::Widget::GetWidgetForNativeWindow(window)->GetNativeView();
}
// Add/remove observer.
- virtual void AddObserver(ModalDialogHostObserver* observer) override {
+ void AddObserver(ModalDialogHostObserver* observer) override {
observer_list_.AddObserver(observer);
}
- virtual void RemoveObserver(ModalDialogHostObserver* observer) override {
+ void RemoveObserver(ModalDialogHostObserver* observer) override {
observer_list_.RemoveObserver(observer);
}
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view_layout.h ('k') | chrome/browser/ui/views/frame/browser_view_layout_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698