chrome/browser/ui/views/frame/browser_frame.h - Issue 686463004: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_frame.h

Issue 686463004: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/browser_desktop_window_tree_host_x11.cc ('k') | chrome/browser/ui/views/frame/browser_frame_ash.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_frame.h

diff --git a/chrome/browser/ui/views/frame/browser_frame.h b/chrome/browser/ui/views/frame/browser_frame.h

index 370b7588c7dea7d6751da8e897c977600d811da2..4ce62597bf6e0f2ff6dbbaccf5dc8afd24782160 100644

--- a/chrome/browser/ui/views/frame/browser_frame.h

+++ b/chrome/browser/ui/views/frame/browser_frame.h

@@ -43,7 +43,7 @@ class BrowserFrame

public views::ContextMenuController {

public:

explicit BrowserFrame(BrowserView* browser_view);

- virtual ~BrowserFrame();

+ ~BrowserFrame() override;

static const gfx::FontList& GetTitleFontList();

@@ -87,18 +87,18 @@ class BrowserFrame

ui::WindowShowState* show_state) const;

// Overridden from views::Widget:

- virtual views::internal::RootView* CreateRootView() override;

- virtual views::NonClientFrameView* CreateNonClientFrameView() override;

- virtual bool GetAccelerator(int command_id,

- ui::Accelerator* accelerator) const override;

- virtual ui::ThemeProvider* GetThemeProvider() const override;

- virtual void SchedulePaintInRect(const gfx::Rect& rect) override;

- virtual void OnNativeWidgetActivationChanged(bool active) override;

+ views::internal::RootView* CreateRootView() override;

+ views::NonClientFrameView* CreateNonClientFrameView() override;

+ bool GetAccelerator(int command_id,

+ ui::Accelerator* accelerator) const override;

+ ui::ThemeProvider* GetThemeProvider() const override;

+ void SchedulePaintInRect(const gfx::Rect& rect) override;

+ void OnNativeWidgetActivationChanged(bool active) override;

// Overridden from views::ContextMenuController:

- virtual void ShowContextMenuForView(views::View* source,

- const gfx::Point& p,

- ui::MenuSourceType source_type) override;

+ void ShowContextMenuForView(views::View* source,

+ const gfx::Point& p,

+ ui::MenuSourceType source_type) override;

// Returns true if we should leave any offset at the frame caption. Typically

// when the frame is maximized/full screen we want to leave no offset at the