Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 67573003: Android: moves chrome/ to use long for JNI (Closed)

Created:
7 years, 1 month ago by bulach
Modified:
7 years, 1 month ago
CC:
chromium-reviews, davidben+watch_chromium.org, tim+watch_chromium.org, cbentzel+watch_chromium.org, gavinp+prer_chromium.org, benquan, haitaol+watch_chromium.org, browser-components-watch_chromium.org, tburkard+watch_chromium.org, dominich+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, rsimha+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Android: moves chrome/ to use long for JNI BUG=317523 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+368 lines, -364 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java View 2 chunks +24 lines, -24 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeHttpAuthHandler.java View 2 chunks +11 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ContentViewUtil.java View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ForeignSessionHelper.java View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/NavigationPopup.java View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/NewTabPagePrefs.java View 2 chunks +11 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/PasswordUIView.java View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/RecentlyClosedBridge.java View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/TabBase.java View 5 chunks +11 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/TtsPlatformImpl.java View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerAndroid.java View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java View 2 chunks +11 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/database/SQLiteCursor.java View 3 chunks +14 lines, -14 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/AutoLoginDelegate.java View 7 chunks +9 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBarDelegate.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBarDelegate.java View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java View 2 chunks +17 lines, -17 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxPrerender.java View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandler.java View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/profiles/Profile.java View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java View 2 chunks +13 lines, -13 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/signin/OAuth2TokenService.java View 4 chunks +11 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java View 3 chunks +40 lines, -39 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderRequestTest.java View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellTab.java View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/android/testshell/testshell_tab.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/bookmarks/bookmarks_bridge.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/chrome_web_contents_delegate_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/content_view_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/android/favicon_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/foreign_session_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/new_tab_page_prefs.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/omnibox/omnibox_prerender.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/password_ui_view_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/provider/chrome_browser_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/recently_closed_tabs_bridge.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/shortcut_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/signin/signin_manager_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/tab_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/android/sqlite_cursor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/external_prerender_handler_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/external_prerender_handler_android.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/android_profile_oauth2_token_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/speech/tts_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/autofill/autofill_popup_view_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/chrome_http_auth_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/infobars/auto_login_infobar_delegate_android.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/android/infobars/confirm_infobar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/infobars/infobar_container_android.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/android/infobars/translate_infobar.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/javascript_app_modal_dialog_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/navigation_popup.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/website_settings_popup_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_android.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bulach
yaron, thanks a ton for all these reviews! this requires a downstream companion, but I ...
7 years, 1 month ago (2013-11-19 10:16:46 UTC) #1
Yaron
lgtm
7 years, 1 month ago (2013-11-20 00:44:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/67573003/1
7 years, 1 month ago (2013-11-20 10:33:03 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=37180
7 years, 1 month ago (2013-11-20 10:50:24 UTC) #4
bulach
jochen, can I have a RS for: chrome/browser/autofill/android/personal_data_manager_android.cc chrome/browser/history/android/sqlite_cursor.cc chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc chrome/browser/prerender/external_prerender_handler_android.cc chrome/browser/prerender/external_prerender_handler_android.h chrome/browser/profiles/profile_android.cc chrome/browser/signin/android_profile_oauth2_token_service.cc chrome/browser/speech/tts_android.cc ...
7 years, 1 month ago (2013-11-20 11:16:06 UTC) #5
jochen (gone - plz use gerrit)
rs lgtm
7 years, 1 month ago (2013-11-20 14:03:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/67573003/1
7 years, 1 month ago (2013-11-20 16:22:55 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-20 20:39:20 UTC) #8
Message was sent while issue was closed. 
Change committed as 236278

Powered by Google App Engine
This is Rietveld 408576698