chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellTab.java - Issue 67573003: Android: moves chrome/ to use long for JNI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellTab.java

Issue 67573003: Android: moves chrome/ to use long for JNI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderRequestTest.java ('k') | chrome/android/testshell/testshell_tab.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellTab.java

diff --git a/chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellTab.java b/chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellTab.java

index c19103ce6f765be7afde2471b8d66a4d617e6eaa..846588fed3ac79139b0cd276693a7939e2485064 100644

--- a/chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellTab.java

+++ b/chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellTab.java

@@ -19,7 +19,7 @@ import org.chromium.ui.base.WindowAndroid;

* and extends {@link TabBase}.

public class TestShellTab extends TabBase {

- private int mNativeTestShellTab;

+ private long mNativeTestShellTab;

private CleanupReference mCleanupReference;

@@ -103,8 +103,8 @@ public class TestShellTab extends TabBase {

}

private static final class DestroyRunnable implements Runnable {

- private final int mNativeTestShellTab;

- private DestroyRunnable(int nativeTestShellTab) {

+ private final long mNativeTestShellTab;

+ private DestroyRunnable(long nativeTestShellTab) {

mNativeTestShellTab = nativeTestShellTab;

}

@Override

@@ -139,7 +139,7 @@ public class TestShellTab extends TabBase {

}

- private native int nativeInit();

- private static native void nativeDestroy(int nativeTestShellTab);

- private native String nativeFixupUrl(int nativeTestShellTab, String url);

+ private native long nativeInit();

+ private static native void nativeDestroy(long nativeTestShellTab);

+ private native String nativeFixupUrl(long nativeTestShellTab, String url);

}