chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerAndroid.java - Issue 67573003: Android: moves chrome/ to use long for JNI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerAndroid.java

Issue 67573003: Android: moves chrome/ to use long for JNI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerAndroid.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerAndroid.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerAndroid.java

index ab30ea06af3b5afffcbe7d9d0d2381b03db61fe5..002608123e81429c9aa6f1be957c9a3b61c4e730 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerAndroid.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerAndroid.java

@@ -19,7 +19,7 @@ public class AutofillDialogControllerAndroid {

private static AutofillDialogFactory sDialogFactory;

private static boolean sAllowInsecureDialogsForTesting = false;

- private int mNativeDelegate; // could be 0 after onDestroy().

+ private long mNativeDelegate; // could be 0 after onDestroy().

private AutofillDialog mDialog;

/**

@@ -108,7 +108,7 @@ public class AutofillDialogControllerAndroid {

}

private AutofillDialogControllerAndroid(

- final int nativeAutofillDialogControllerAndroid,

+ final long nativeAutofillDialogControllerAndroid,

final WindowAndroid windowAndroid,

final boolean requestFullBillingAddress, final boolean requestShippingAddress,

final boolean requestPhoneNumbers,

@@ -159,7 +159,7 @@ public class AutofillDialogControllerAndroid {

@CalledByNative

private static AutofillDialogControllerAndroid create(

- final int nativeAutofillDialogControllerAndroid,

+ final long nativeAutofillDialogControllerAndroid,

final WindowAndroid windowAndroid,

final boolean requestFullBillingAddress, final boolean requestShippingAddress,

final boolean requestPhoneNumbers,

@@ -198,8 +198,8 @@ public class AutofillDialogControllerAndroid {

// Calls from Java to C++ AutofillDialogControllerAndroid:

- private native void nativeDialogCancel(int nativeAutofillDialogControllerAndroid);

- private native void nativeDialogContinue(int nativeAutofillDialogControllerAndroid,

+ private native void nativeDialogCancel(long nativeAutofillDialogControllerAndroid);

+ private native void nativeDialogContinue(long nativeAutofillDialogControllerAndroid,

Object fullWallet,

boolean lastUsedChoiceIsAutofill, String lastUsedAccountName,

String guidLastUsedBilling, String guidLastUsedShipping, String guidLastUsedCard);