chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java - Issue 67573003: Android: moves chrome/ to use long for JNI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java

Issue 67573003: Android: moves chrome/ to use long for JNI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ForeignSessionHelper.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/NavigationPopup.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java b/chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java

index 184221d14cb34b9745925fa87d3b784f7cb37844..a25f7f29fe884efb828dec24a74655b09081998b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java

@@ -27,7 +27,7 @@ public class JavascriptAppModalDialog implements DialogInterface.OnClickListener

private final String mTitle;

private final String mMessage;

private final boolean mShouldShowSuppressCheckBox;

- private int mNativeDialogPointer;

+ private long mNativeDialogPointer;

private AlertDialog mDialog;

private CheckBox mSuppressCheckBox;

private TextView mPrompTextView;

@@ -66,7 +66,7 @@ public class JavascriptAppModalDialog implements DialogInterface.OnClickListener

}

@CalledByNative

- void showJavascriptAppModalDialog(WindowAndroid window, int nativeDialogPointer) {

+ void showJavascriptAppModalDialog(WindowAndroid window, long nativeDialogPointer) {

assert window != null;

Context context = window.getContext();

@@ -272,10 +272,10 @@ public class JavascriptAppModalDialog implements DialogInterface.OnClickListener

}

- private native void nativeDidAcceptAppModalDialog(int nativeJavascriptAppModalDialogAndroid,

+ private native void nativeDidAcceptAppModalDialog(long nativeJavascriptAppModalDialogAndroid,

String prompt, boolean suppress);

- private native void nativeDidCancelAppModalDialog(int nativeJavascriptAppModalDialogAndroid,

+ private native void nativeDidCancelAppModalDialog(long nativeJavascriptAppModalDialogAndroid,

boolean suppress);

private static native JavascriptAppModalDialog nativeGetCurrentModalDialog();