chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java - Issue 67573003: Android: moves chrome/ to use long for JNI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java

Issue 67573003: Android: moves chrome/ to use long for JNI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerAndroid.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java

index bbac1def40766c060a164ea85d70d3ced023a0b8..1586210e87cfc2669ece919148d32cb21017a5fe 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java

@@ -18,17 +18,17 @@ import org.chromium.ui.base.WindowAndroid;

@JNINamespace("autofill")

public class AutofillPopupGlue implements AutofillPopupDelegate{

- private final int mNativeAutofillPopup;

+ private final long mNativeAutofillPopup;

private final AutofillPopup mAutofillPopup;

- public AutofillPopupGlue(int nativeAutofillPopupViewAndroid, WindowAndroid windowAndroid,

+ public AutofillPopupGlue(long nativeAutofillPopupViewAndroid, WindowAndroid windowAndroid,

ViewAndroidDelegate containerViewDelegate) {

mNativeAutofillPopup = nativeAutofillPopupViewAndroid;

mAutofillPopup = new AutofillPopup(windowAndroid.getContext(), containerViewDelegate, this);

}

@CalledByNative

- private static AutofillPopupGlue create(int nativeAutofillPopupViewAndroid,

+ private static AutofillPopupGlue create(long nativeAutofillPopupViewAndroid,

WindowAndroid windowAndroid, ViewAndroid viewAndroid) {

return new AutofillPopupGlue(nativeAutofillPopupViewAndroid, windowAndroid,

viewAndroid.getViewAndroidDelegate());

@@ -93,7 +93,7 @@ public class AutofillPopupGlue implements AutofillPopupDelegate{

array[index] = new AutofillSuggestion(label, sublabel, uniqueId);

}

- private native void nativeRequestHide(int nativeAutofillPopupViewAndroid);

- private native void nativeSuggestionSelected(int nativeAutofillPopupViewAndroid,

+ private native void nativeRequestHide(long nativeAutofillPopupViewAndroid);

+ private native void nativeSuggestionSelected(long nativeAutofillPopupViewAndroid,

int listIndex);

}