Have ElementTraversal / NodeTraversal's next() methods take a reference

Have ElementTraversal / NodeTraversal's next() methods take a reference

Have ElementTraversal / NodeTraversal's next() methods take a reference instead
of a pointer and the argument is expected to be non-null. This makes the code
look safer.

R=adamk

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161835

[Inactive, 2013-11-08 23:04:30]

I am planning to update other ElementTraversal / NodeTraversal methods in
follow-up patches for consistency.

I am merely splitting the work to minimize patch size and make it more
reviewable.

[adamk, 2013-11-08 23:10:58]

lgtm rs=me (didn't look at every single line of code but this change looks
pretty mechanical)

[commit-bot: I haz the power, 2013-11-11 14:00:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/67473002/1

[commit-bot: I haz the power, 2013-11-11 14:00:54]

Failed to apply patch for Source/core/editing/VisibleUnits.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/editing/VisibleUnits.cpp
  Hunk #2 FAILED at 1225.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/editing/VisibleUnits.cpp.rej

Patch:       Source/core/editing/VisibleUnits.cpp
Index: Source/core/editing/VisibleUnits.cpp
diff --git a/Source/core/editing/VisibleUnits.cpp
b/Source/core/editing/VisibleUnits.cpp
index
6041d27367becdd61e0ab953b24de07433efc390..9b1014863a90f03ebb7add07753529931382cfe3
100644
--- a/Source/core/editing/VisibleUnits.cpp
+++ b/Source/core/editing/VisibleUnits.cpp
@@ -1191,19 +1191,19 @@ VisiblePosition endOfParagraph(const VisiblePosition &c,
EditingBoundaryCrossing
             break;
         if (boundaryCrossingRule == CanSkipOverEditingBoundary) {
             while (n && n->rendererIsEditable() !=
startNode->rendererIsEditable())
-                n = NodeTraversal::next(n, stayInsideBlock);
+                n = NodeTraversal::next(*n, stayInsideBlock);
             if (!n || !n->isDescendantOf(highestRoot))
                 break;
         }
 
         RenderObject* r = n->renderer();
         if (!r) {
-            n = NodeTraversal::next(n, stayInsideBlock);
+            n = NodeTraversal::next(*n, stayInsideBlock);
             continue;
         }
         RenderStyle* style = r->style();
         if (style->visibility() != VISIBLE) {
-            n = NodeTraversal::next(n, stayInsideBlock);
+            n = NodeTraversal::next(*n, stayInsideBlock);
             continue;
         }
 
@@ -1225,13 +1225,14 @@ VisiblePosition endOfParagraph(const VisiblePosition &c,
EditingBoundaryCrossing
             }
             node = n;
             offset = r->caretMaxOffset();
-            n = NodeTraversal::next(n, stayInsideBlock);
+            n = NodeTraversal::next(*n, stayInsideBlock);
         } else if (editingIgnoresContent(n) || isTableElement(n)) {
             node = n;
             type = Position::PositionIsAfterAnchor;
             n = NodeTraversal::nextSkippingChildren(n, stayInsideBlock);
-        } else
-            n = NodeTraversal::next(n, stayInsideBlock);
+        } else {
+            n = NodeTraversal::next(*n, stayInsideBlock);
+        }
     }
 
     if (type == Position::PositionIsOffsetInAnchor)

[commit-bot: I haz the power, 2013-11-11 14:18:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/67473002/80001

[commit-bot: I haz the power, 2013-11-12 16:57:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/67473002/80001

[commit-bot: I haz the power, 2013-11-12 18:06:48]

Change committed as 161835