Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: Source/core/dom/Node.cpp

Issue 67473002: Have ElementTraversal / NodeTraversal's next() methods take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase on master Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/LiveNodeList.h ('k') | Source/core/dom/NodeIterator.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 719 matching lines...) Expand 10 before | Expand all | Expand 10 after
730 } 730 }
731 731
732 bool Node::inActiveDocument() const 732 bool Node::inActiveDocument() const
733 { 733 {
734 return inDocument() && document().isActive(); 734 return inDocument() && document().isActive();
735 } 735 }
736 736
737 void Node::lazyAttach() 737 void Node::lazyAttach()
738 { 738 {
739 markAncestorsWithChildNeedsStyleRecalc(); 739 markAncestorsWithChildNeedsStyleRecalc();
740 for (Node* node = this; node; node = NodeTraversal::next(node, this)) { 740 for (Node* node = this; node; node = NodeTraversal::next(*node, this)) {
741 node->setAttached(); 741 node->setAttached();
742 node->setStyleChange(NeedsReattachStyleChange); 742 node->setStyleChange(NeedsReattachStyleChange);
743 if (node->isContainerNode()) 743 if (node->isContainerNode())
744 node->setChildNeedsStyleRecalc(); 744 node->setChildNeedsStyleRecalc();
745 for (ShadowRoot* root = node->youngestShadowRoot(); root; root = root->o lderShadowRoot()) 745 for (ShadowRoot* root = node->youngestShadowRoot(); root; root = root->o lderShadowRoot())
746 root->lazyAttach(); 746 root->lazyAttach();
747 } 747 }
748 } 748 }
749 749
750 Node* Node::focusDelegate() 750 Node* Node::focusDelegate()
(...skipping 1122 matching lines...) Expand 10 before | Expand all | Expand 10 after
1873 break; 1873 break;
1874 default: 1874 default:
1875 break; 1875 break;
1876 } 1876 }
1877 } 1877 }
1878 fprintf(stderr, "\n"); 1878 fprintf(stderr, "\n");
1879 } 1879 }
1880 1880
1881 static void traverseTreeAndMark(const String& baseIndent, const Node* rootNode, const Node* markedNode1, const char* markedLabel1, const Node* markedNode2, cons t char* markedLabel2) 1881 static void traverseTreeAndMark(const String& baseIndent, const Node* rootNode, const Node* markedNode1, const char* markedLabel1, const Node* markedNode2, cons t char* markedLabel2)
1882 { 1882 {
1883 for (const Node* node = rootNode; node; node = NodeTraversal::next(node)) { 1883 for (const Node* node = rootNode; node; node = NodeTraversal::next(*node)) {
1884 if (node == markedNode1) 1884 if (node == markedNode1)
1885 fprintf(stderr, "%s", markedLabel1); 1885 fprintf(stderr, "%s", markedLabel1);
1886 if (node == markedNode2) 1886 if (node == markedNode2)
1887 fprintf(stderr, "%s", markedLabel2); 1887 fprintf(stderr, "%s", markedLabel2);
1888 1888
1889 StringBuilder indent; 1889 StringBuilder indent;
1890 indent.append(baseIndent); 1890 indent.append(baseIndent);
1891 for (const Node* tmpNode = node; tmpNode && tmpNode != rootNode; tmpNode = tmpNode->parentOrShadowHostNode()) 1891 for (const Node* tmpNode = node; tmpNode && tmpNode != rootNode; tmpNode = tmpNode->parentOrShadowHostNode())
1892 indent.append('\t'); 1892 indent.append('\t');
1893 fprintf(stderr, "%s", indent.toString().utf8().data()); 1893 fprintf(stderr, "%s", indent.toString().utf8().data());
(...skipping 749 matching lines...) Expand 10 before | Expand all | Expand 10 after
2643 node->showTreeForThis(); 2643 node->showTreeForThis();
2644 } 2644 }
2645 2645
2646 void showNodePath(const WebCore::Node* node) 2646 void showNodePath(const WebCore::Node* node)
2647 { 2647 {
2648 if (node) 2648 if (node)
2649 node->showNodePathForThis(); 2649 node->showNodePathForThis();
2650 } 2650 }
2651 2651
2652 #endif 2652 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/LiveNodeList.h ('k') | Source/core/dom/NodeIterator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698