Source/core/editing/InsertParagraphSeparatorCommand.cpp - Issue 67473002: Have ElementTraversal / NodeTraversal's next() methods take a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/InsertParagraphSeparatorCommand.cpp

Issue 67473002: Have ElementTraversal / NodeTraversal's next() methods take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase on master Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/InsertParagraphSeparatorCommand.cpp

diff --git a/Source/core/editing/InsertParagraphSeparatorCommand.cpp b/Source/core/editing/InsertParagraphSeparatorCommand.cpp

index 5c129488e43494cf14ca750f4e237fcb0b2280e3..ddfe1d26d77ea1bd4ae22fd3e991d451e593da23 100644

--- a/Source/core/editing/InsertParagraphSeparatorCommand.cpp

+++ b/Source/core/editing/InsertParagraphSeparatorCommand.cpp

@@ -395,7 +395,7 @@ void InsertParagraphSeparatorCommand::doApply()

else {

Node* splitTo = insertionPosition.containerNode();

if (splitTo->isTextNode() && insertionPosition.offsetInContainerNode() >= caretMaxOffset(splitTo))

- splitTo = NodeTraversal::next(splitTo, startBlock.get());

+ splitTo = NodeTraversal::next(*splitTo, startBlock.get());

ASSERT(splitTo);

splitTreeToNode(splitTo, startBlock.get());

« no previous file with comments | « Source/core/editing/FrameSelection.cpp ('k') | Source/core/editing/ReplaceSelectionCommand.h » ('j') | no next file with comments »