Source/core/html/HTMLCollection.h - Issue 67473002: Have ElementTraversal / NodeTraversal's next() methods take a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLCollection.h

Issue 67473002: Have ElementTraversal / NodeTraversal's next() methods take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase on master Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLCollection.h

diff --git a/Source/core/html/HTMLCollection.h b/Source/core/html/HTMLCollection.h

index 4ff5e71f5d014d3adf6c8320dd7c6d2fe7264cb2..e1843f92ad7f38dbea49c0938b5c1e410737ab92 100644

--- a/Source/core/html/HTMLCollection.h

+++ b/Source/core/html/HTMLCollection.h

@@ -62,7 +62,7 @@ public:

virtual Element* virtualItemAfter(unsigned& offsetInArray, Element*) const;

Element* traverseFirstElement(unsigned& offsetInArray, ContainerNode* root) const;

- Element* traverseForwardToOffset(unsigned offset, Element* currentElement, unsigned& currentOffset, unsigned& offsetInArray, ContainerNode* root) const;

+ Element* traverseForwardToOffset(unsigned offset, Element& currentElement, unsigned& currentOffset, unsigned& offsetInArray, ContainerNode* root) const;

protected:

HTMLCollection(Node* base, CollectionType, ItemAfterOverrideType);

@@ -77,7 +77,7 @@ protected:

private:

bool checkForNameMatch(Element*, bool checkName, const AtomicString& name) const;

- Element* traverseNextElement(unsigned& offsetInArray, Element* previous, ContainerNode* root) const;

+ Element* traverseNextElement(unsigned& offsetInArray, Element& previous, ContainerNode* root) const;

virtual bool isLiveNodeList() const OVERRIDE { ASSERT_NOT_REACHED(); return true; }

« no previous file with comments | « Source/core/html/FormAssociatedElement.cpp ('k') | Source/core/html/HTMLCollection.cpp » ('j') | no next file with comments »