Source/core/xml/XPathNodeSet.cpp - Issue 67473002: Have ElementTraversal / NodeTraversal's next() methods take a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/XPathNodeSet.cpp

Issue 67473002: Have ElementTraversal / NodeTraversal's next() methods take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase on master Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/xml/XPathNodeSet.cpp

diff --git a/Source/core/xml/XPathNodeSet.cpp b/Source/core/xml/XPathNodeSet.cpp

index c6219947ab493e31da3ba8fc52ec1663d15575ea..fa8d2d71c61d9a4ec3be9310ead05a55c616222b 100644

--- a/Source/core/xml/XPathNodeSet.cpp

+++ b/Source/core/xml/XPathNodeSet.cpp

@@ -207,7 +207,7 @@ void NodeSet::traversalSort() const

Vector<RefPtr<Node> > sortedNodes;

sortedNodes.reserveInitialCapacity(nodeCount);

- for (Node* n = findRootNode(m_nodes.first().get()); n; n = NodeTraversal::next(n)) {

+ for (Node* n = findRootNode(m_nodes.first().get()); n; n = NodeTraversal::next(*n)) {

if (nodes.contains(n))

sortedNodes.append(n);

« no previous file with comments | « Source/core/svg/animation/SMILTimeContainer.cpp ('k') | Source/core/xml/XPathStep.cpp » ('j') | no next file with comments »