Source/core/editing/TextIterator.cpp - Issue 67473002: Have ElementTraversal / NodeTraversal's next() methods take a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/TextIterator.cpp

Issue 67473002: Have ElementTraversal / NodeTraversal's next() methods take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase on master Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/TextIterator.cpp

diff --git a/Source/core/editing/TextIterator.cpp b/Source/core/editing/TextIterator.cpp

index 6707368338caeb3303ee5a110db3df32ce3d9be2..50b33fa976b04c36a2a2898b48f20a43260b780a 100644

--- a/Source/core/editing/TextIterator.cpp

+++ b/Source/core/editing/TextIterator.cpp

@@ -386,7 +386,7 @@ void TextIterator::advance()

if (!next) {

next = m_node->nextSibling();

if (!next) {

- bool pastEnd = NodeTraversal::next(m_node) == m_pastEndNode;

+ bool pastEnd = NodeTraversal::next(*m_node) == m_pastEndNode;

Node* parentNode = m_node->parentOrShadowHostNode();

while (!next && parentNode) {

if ((pastEnd && parentNode == m_endContainer) || m_endContainer->isDescendantOf(parentNode))

« no previous file with comments | « Source/core/editing/SpellChecker.cpp ('k') | Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »