Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 67373003: Remove custom code for JavaScriptCallFrame.setVariableValue() operation (Closed)

Created:
7 years, 1 month ago by Inactive
Modified:
7 years, 1 month ago
Reviewers:
haraken, pfeldman
CC:
blink-reviews, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, arv+blink, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, kojih, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove custom code for JavaScriptCallFrame.setVariableValue() operation Remove custom code for JavaScriptCallFrame.setVariableValue() operation by using ScriptValue instead of v8::Value on the implementation side and by marking the arguments as optional to behave the same way. TEST=inspector-protocol/debugger/debugger-setVariableValue.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161831

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -14 lines) Patch
M Source/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
For reference, the generated code looks like: static void setVariableValueMethod(const v8::FunctionCallbackInfo<v8::Value>& info) { JavaScriptCallFrame* imp ...
7 years, 1 month ago (2013-11-08 21:28:53 UTC) #1
haraken
LGTM.
7 years, 1 month ago (2013-11-08 21:56:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/67373003/1
7 years, 1 month ago (2013-11-11 13:59:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/67373003/1
7 years, 1 month ago (2013-11-12 16:42:44 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-12 17:26:10 UTC) #5
Message was sent while issue was closed.
Change committed as 161831

Powered by Google App Engine
This is Rietveld 408576698