Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Unified Diff: Source/core/inspector/JavaScriptCallFrame.h

Issue 67373003: Remove custom code for JavaScriptCallFrame.setVariableValue() operation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/JavaScriptCallFrame.h
diff --git a/Source/core/inspector/JavaScriptCallFrame.h b/Source/core/inspector/JavaScriptCallFrame.h
index 8d511c73ff2000323c991303e2306dfaa423ca2b..ac0c0350b614765836a3ed44520132f39c979e42 100644
--- a/Source/core/inspector/JavaScriptCallFrame.h
+++ b/Source/core/inspector/JavaScriptCallFrame.h
@@ -40,6 +40,8 @@
namespace WebCore {
+class ScriptValue;
+
class JavaScriptCallFrame : public RefCounted<JavaScriptCallFrame>, public ScriptWrappable {
public:
static PassRefPtr<JavaScriptCallFrame> create(v8::Handle<v8::Context> debuggerContext, v8::Handle<v8::Object> callFrame)
@@ -64,7 +66,7 @@ public:
v8::Handle<v8::Value> evaluate(const String& expression);
v8::Handle<v8::Value> restart();
- v8::Handle<v8::Value> setVariableValue(int scopeNumber, const String& variableName, v8::Handle<v8::Value> newValue);
+ ScriptValue setVariableValue(int scopeNumber, const String& variableName, const ScriptValue& newValue);
v8::Handle<v8::Object> innerCallFrame();
private:
« no previous file with comments | « Source/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp ('k') | Source/core/inspector/JavaScriptCallFrame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698