Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: Source/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp

Issue 67373003: Remove custom code for JavaScriptCallFrame.setVariableValue() operation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/inspector/JavaScriptCallFrame.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 30 matching lines...) Expand all
41 String expression = toWebCoreStringWithUndefinedOrNullCheck(info[0]); 41 String expression = toWebCoreStringWithUndefinedOrNullCheck(info[0]);
42 v8SetReturnValue(info, impl->evaluate(expression)); 42 v8SetReturnValue(info, impl->evaluate(expression));
43 } 43 }
44 44
45 void V8JavaScriptCallFrame::restartMethodCustom(const v8::FunctionCallbackInfo<v 8::Value>& info) 45 void V8JavaScriptCallFrame::restartMethodCustom(const v8::FunctionCallbackInfo<v 8::Value>& info)
46 { 46 {
47 JavaScriptCallFrame* impl = V8JavaScriptCallFrame::toNative(info.Holder()); 47 JavaScriptCallFrame* impl = V8JavaScriptCallFrame::toNative(info.Holder());
48 v8SetReturnValue(info, impl->restart()); 48 v8SetReturnValue(info, impl->restart());
49 } 49 }
50 50
51 void V8JavaScriptCallFrame::setVariableValueMethodCustom(const v8::FunctionCallb ackInfo<v8::Value>& info)
52 {
53 JavaScriptCallFrame* impl = V8JavaScriptCallFrame::toNative(info.Holder());
54 int scopeIndex = info[0]->Int32Value();
55 String variableName = toWebCoreStringWithUndefinedOrNullCheck(info[1]);
56 v8::Handle<v8::Value> newValue = info[2];
57 v8SetReturnValue(info, impl->setVariableValue(scopeIndex, variableName, newV alue));
58 }
59
60 void V8JavaScriptCallFrame::scopeChainAttributeGetterCustom(const v8::PropertyCa llbackInfo<v8::Value>& info) 51 void V8JavaScriptCallFrame::scopeChainAttributeGetterCustom(const v8::PropertyCa llbackInfo<v8::Value>& info)
61 { 52 {
62 JavaScriptCallFrame* impl = V8JavaScriptCallFrame::toNative(info.Holder()); 53 JavaScriptCallFrame* impl = V8JavaScriptCallFrame::toNative(info.Holder());
63 v8SetReturnValue(info, impl->scopeChain()); 54 v8SetReturnValue(info, impl->scopeChain());
64 } 55 }
65 56
66 void V8JavaScriptCallFrame::scopeTypeMethodCustom(const v8::FunctionCallbackInfo <v8::Value>& info) 57 void V8JavaScriptCallFrame::scopeTypeMethodCustom(const v8::FunctionCallbackInfo <v8::Value>& info)
67 { 58 {
68 JavaScriptCallFrame* impl = V8JavaScriptCallFrame::toNative(info.Holder()); 59 JavaScriptCallFrame* impl = V8JavaScriptCallFrame::toNative(info.Holder());
69 int scopeIndex = info[0]->Int32Value(); 60 int scopeIndex = info[0]->Int32Value();
(...skipping 12 matching lines...) Expand all
82 v8SetReturnValue(info, impl->returnValue()); 73 v8SetReturnValue(info, impl->returnValue());
83 } 74 }
84 75
85 void V8JavaScriptCallFrame::typeAttributeGetterCustom(const v8::PropertyCallback Info<v8::Value>& info) 76 void V8JavaScriptCallFrame::typeAttributeGetterCustom(const v8::PropertyCallback Info<v8::Value>& info)
86 { 77 {
87 v8SetReturnValue(info, v8::String::NewSymbol("function")); 78 v8SetReturnValue(info, v8::String::NewSymbol("function"));
88 } 79 }
89 80
90 } // namespace WebCore 81 } // namespace WebCore
91 82
OLDNEW
« no previous file with comments | « no previous file | Source/core/inspector/JavaScriptCallFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698