Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1021)

Unified Diff: Source/core/inspector/JavaScriptCallFrame.cpp

Issue 67373003: Remove custom code for JavaScriptCallFrame.setVariableValue() operation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/JavaScriptCallFrame.h ('k') | Source/core/inspector/JavaScriptCallFrame.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/JavaScriptCallFrame.cpp
diff --git a/Source/core/inspector/JavaScriptCallFrame.cpp b/Source/core/inspector/JavaScriptCallFrame.cpp
index 77e3b1ac5b011d50658751c5d6c2ff99031f6113..3d05d62ee942984d0df0ed53cbaf3dda0eecf86e 100644
--- a/Source/core/inspector/JavaScriptCallFrame.cpp
+++ b/Source/core/inspector/JavaScriptCallFrame.cpp
@@ -31,6 +31,7 @@
#include "config.h"
#include "core/inspector/JavaScriptCallFrame.h"
+#include "bindings/v8/ScriptValue.h"
#include "bindings/v8/V8Binding.h"
namespace WebCore {
@@ -165,16 +166,16 @@ v8::Handle<v8::Object> JavaScriptCallFrame::innerCallFrame()
return m_callFrame.newLocal(m_isolate);
}
-v8::Handle<v8::Value> JavaScriptCallFrame::setVariableValue(int scopeNumber, const String& variableName, v8::Handle<v8::Value> newValue)
+ScriptValue JavaScriptCallFrame::setVariableValue(int scopeNumber, const String& variableName, const ScriptValue& newValue)
{
v8::Handle<v8::Object> callFrame = m_callFrame.newLocal(m_isolate);
v8::Handle<v8::Function> setVariableValueFunction = v8::Handle<v8::Function>::Cast(callFrame->Get(v8::String::NewSymbol("setVariableValue")));
v8::Handle<v8::Value> argv[] = {
v8::Handle<v8::Value>(v8::Integer::New(scopeNumber, m_isolate)),
v8String(variableName, m_isolate),
- newValue
+ newValue.v8Value()
};
- return setVariableValueFunction->Call(callFrame, 3, argv);
+ return ScriptValue(setVariableValueFunction->Call(callFrame, 3, argv), m_isolate);
}
} // namespace WebCore
« no previous file with comments | « Source/core/inspector/JavaScriptCallFrame.h ('k') | Source/core/inspector/JavaScriptCallFrame.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698