Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Side by Side Diff: Source/core/inspector/JavaScriptCallFrame.h

Issue 67373003: Remove custom code for JavaScriptCallFrame.setVariableValue() operation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010, Google Inc. All rights reserved. 2 * Copyright (c) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 22 matching lines...) Expand all
33 33
34 34
35 #include "bindings/v8/ScopedPersistent.h" 35 #include "bindings/v8/ScopedPersistent.h"
36 #include "bindings/v8/ScriptWrappable.h" 36 #include "bindings/v8/ScriptWrappable.h"
37 #include <v8-debug.h> 37 #include <v8-debug.h>
38 #include "wtf/RefCounted.h" 38 #include "wtf/RefCounted.h"
39 #include "wtf/text/WTFString.h" 39 #include "wtf/text/WTFString.h"
40 40
41 namespace WebCore { 41 namespace WebCore {
42 42
43 class ScriptValue;
44
43 class JavaScriptCallFrame : public RefCounted<JavaScriptCallFrame>, public Scrip tWrappable { 45 class JavaScriptCallFrame : public RefCounted<JavaScriptCallFrame>, public Scrip tWrappable {
44 public: 46 public:
45 static PassRefPtr<JavaScriptCallFrame> create(v8::Handle<v8::Context> debugg erContext, v8::Handle<v8::Object> callFrame) 47 static PassRefPtr<JavaScriptCallFrame> create(v8::Handle<v8::Context> debugg erContext, v8::Handle<v8::Object> callFrame)
46 { 48 {
47 return adoptRef(new JavaScriptCallFrame(debuggerContext, callFrame)); 49 return adoptRef(new JavaScriptCallFrame(debuggerContext, callFrame));
48 } 50 }
49 ~JavaScriptCallFrame(); 51 ~JavaScriptCallFrame();
50 52
51 JavaScriptCallFrame* caller(); 53 JavaScriptCallFrame* caller();
52 54
53 int sourceID() const; 55 int sourceID() const;
54 int line() const; 56 int line() const;
55 int column() const; 57 int column() const;
56 String functionName() const; 58 String functionName() const;
57 59
58 v8::Handle<v8::Value> scopeChain() const; 60 v8::Handle<v8::Value> scopeChain() const;
59 int scopeType(int scopeIndex) const; 61 int scopeType(int scopeIndex) const;
60 v8::Handle<v8::Value> thisObject() const; 62 v8::Handle<v8::Value> thisObject() const;
61 String stepInPositions() const; 63 String stepInPositions() const;
62 bool isAtReturn() const; 64 bool isAtReturn() const;
63 v8::Handle<v8::Value> returnValue() const; 65 v8::Handle<v8::Value> returnValue() const;
64 66
65 v8::Handle<v8::Value> evaluate(const String& expression); 67 v8::Handle<v8::Value> evaluate(const String& expression);
66 v8::Handle<v8::Value> restart(); 68 v8::Handle<v8::Value> restart();
67 v8::Handle<v8::Value> setVariableValue(int scopeNumber, const String& variab leName, v8::Handle<v8::Value> newValue); 69 ScriptValue setVariableValue(int scopeNumber, const String& variableName, co nst ScriptValue& newValue);
68 v8::Handle<v8::Object> innerCallFrame(); 70 v8::Handle<v8::Object> innerCallFrame();
69 71
70 private: 72 private:
71 JavaScriptCallFrame(v8::Handle<v8::Context> debuggerContext, v8::Handle<v8:: Object> callFrame); 73 JavaScriptCallFrame(v8::Handle<v8::Context> debuggerContext, v8::Handle<v8:: Object> callFrame);
72 74
73 v8::Isolate* m_isolate; 75 v8::Isolate* m_isolate;
74 RefPtr<JavaScriptCallFrame> m_caller; 76 RefPtr<JavaScriptCallFrame> m_caller;
75 ScopedPersistent<v8::Context> m_debuggerContext; 77 ScopedPersistent<v8::Context> m_debuggerContext;
76 ScopedPersistent<v8::Object> m_callFrame; 78 ScopedPersistent<v8::Object> m_callFrame;
77 }; 79 };
78 80
79 } // namespace WebCore 81 } // namespace WebCore
80 82
81 83
82 #endif // JavaScriptCallFrame_h 84 #endif // JavaScriptCallFrame_h
OLDNEW
« no previous file with comments | « Source/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp ('k') | Source/core/inspector/JavaScriptCallFrame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698