Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: Source/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp

Issue 67373003: Remove custom code for JavaScriptCallFrame.setVariableValue() operation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/inspector/JavaScriptCallFrame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp
diff --git a/Source/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp b/Source/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp
index 4c9c7443f06bfd5343d3209b22f1f03a2800adb0..581da2d86245ad50130187d2e2994ec6da1353ab 100644
--- a/Source/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp
+++ b/Source/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp
@@ -48,15 +48,6 @@ void V8JavaScriptCallFrame::restartMethodCustom(const v8::FunctionCallbackInfo<v
v8SetReturnValue(info, impl->restart());
}
-void V8JavaScriptCallFrame::setVariableValueMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
-{
- JavaScriptCallFrame* impl = V8JavaScriptCallFrame::toNative(info.Holder());
- int scopeIndex = info[0]->Int32Value();
- String variableName = toWebCoreStringWithUndefinedOrNullCheck(info[1]);
- v8::Handle<v8::Value> newValue = info[2];
- v8SetReturnValue(info, impl->setVariableValue(scopeIndex, variableName, newValue));
-}
-
void V8JavaScriptCallFrame::scopeChainAttributeGetterCustom(const v8::PropertyCallbackInfo<v8::Value>& info)
{
JavaScriptCallFrame* impl = V8JavaScriptCallFrame::toNative(info.Holder());
« no previous file with comments | « no previous file | Source/core/inspector/JavaScriptCallFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698