Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 671173008: Change some roles to "button" instead of "link" where it'd benefit users of (Closed)

Created:
6 years, 2 months ago by Dan Beam
Modified:
6 years, 1 month ago
Reviewers:
aboxhall
CC:
chromium-reviews, dbeam+watch-options_chromium.org, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/src.git@action-link
Project:
chromium
Visibility:
Public.

Description

Change some roles to "button" instead of "link" where it'd benefit users of assistive tecnologies (e.g. screenreaders). Depends on https://codereview.chromium.org/668983004/. BUG=none R=aboxhall@chromium.org TEST=more "button" and less "link" in voice feedback or other ATs Committed: https://crrev.com/75a84f8a3b21f722e8e52be1f99d48ae0acaed90 Cr-Commit-Position: refs/heads/master@{#301375}

Patch Set 1 #

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/crashes.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/extensions/extensions.html View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/local_discovery/local_discovery.css View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/local_discovery/local_discovery.html View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/local_discovery/local_discovery.js View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Dan Beam
this one is still unanswered: https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resources/print_preview/search/destination_list.html#newcode4 i think it can stay a link, but it's ...
6 years, 2 months ago (2014-10-24 02:57:36 UTC) #1
Dan Beam
On 2014/10/24 02:57:36, Dan Beam wrote: > this one is still unanswered: > https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resources/print_preview/search/destination_list.html#newcode4 > ...
6 years, 2 months ago (2014-10-24 03:01:14 UTC) #2
aboxhall
lgtm
6 years, 2 months ago (2014-10-24 23:55:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671173008/20001
6 years, 1 month ago (2014-10-27 15:33:31 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-27 16:17:28 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 16:18:13 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/75a84f8a3b21f722e8e52be1f99d48ae0acaed90
Cr-Commit-Position: refs/heads/master@{#301375}

Powered by Google App Engine
This is Rietveld 408576698