chrome/app/chromium_strings.grd - Issue 671173008: Change some roles to "button" instead of "link" where it'd benefit users of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/chromium_strings.grd

Issue 671173008: Change some roles to "button" instead of "link" where it'd benefit users of (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@action-link

Patch Set: nit Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/chromium_strings.grd

diff --git a/chrome/app/chromium_strings.grd b/chrome/app/chromium_strings.grd

index 7908c0029a8c7fc2df756a1938825618ac62b055..bcfb39d3bce28b840abf9551ca1499c265b33996 100644

--- a/chrome/app/chromium_strings.grd

+++ b/chrome/app/chromium_strings.grd

@@ -429,7 +429,7 @@ be available for now. -->

Use hardware acceleration when available

</message>

- (requires Chromium <ph name="BEGIN_BUTTON"><a is="action-link" id="gpu-mode-reset-restart-button" class="standalone-action-link"></ph>restart<ph name="END_BUTTON"></a></ph>)

+ (requires Chromium <ph name="BEGIN_BUTTON"><a is="action-link" role="button" id="gpu-mode-reset-restart-button" class="standalone-action-link"></ph>restart<ph name="END_BUTTON"></a></ph>)

</message>

Chromium cannot read and write to its data directory:

« no previous file with comments | « no previous file | chrome/app/google_chrome_strings.grd » ('j') | no next file with comments »