chrome/browser/resources/print_preview/search/destination_list.html - Issue 668983004: Add <a is="action-link">, a web component extension of <a> for in-page actions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/print_preview/search/destination_list.html

Issue 668983004: Add <a is="action-link">, a web component extension of <a> for in-page actions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/options/browser_options.html ('K') | « chrome/browser/resources/print_preview/print_preview.html ('k') | chrome/browser/resources/print_preview/search/destination_search.css » ('j') | ui/webui/resources/css/widgets.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <div id="destination-list-template" class="destination-list" hidden>	1 <div id="destination-list-template" class="destination-list" hidden>

2 <header>	2 <header>

3 <h4 class="title"></h4>	3 <h4 class="title"></h4>

4 <button class="action-link link-button" hidden></button>	4 <a is="action-link" class="action-link" hidden></a>
	aboxhall 2014/10/22 21:33:31 Not sure about this - it may or may not pop open a Not sure about this - it may or may not pop open a system dialog. What do you think? Dan Beam 2014/10/23 03:05:44 i think you still need to go "back" to Chrome in t Show quoted text On 2014/10/22 21:33:31, aboxhall wrote: > Not sure about this - it may or may not pop open a system dialog. What do you > think? i think you still need to go "back" to Chrome in the window management, so it's similar enough for me
5 <div class="throbber-container">	5 <div class="throbber-container">

6 <div class="throbber"></div>	6 <div class="throbber"></div>

7 </div>	7 </div>

8 </header>	8 </header>

9 <ul></ul>	9 <ul></ul>

10 <div class="no-destinations-message"	10 <div class="no-destinations-message"

11 i18n-content="noDestinationsMessage"></div>	11 i18n-content="noDestinationsMessage"></div>

12 <footer hidden>	12 <footer hidden>

13 <button class="show-all-button" i18n-content="showAllButtonText"></button>	13 <button class="show-all-button" i18n-content="showAllButtonText"></button>

14 <span class="total"></span>	14 <span class="total"></span>

15 </footer>	15 </footer>

16 </div>	16 </div>

OLD	NEW