chrome/app/google_chrome_strings.grd - Issue 671173008: Change some roles to "button" instead of "link" where it'd benefit users of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/google_chrome_strings.grd

Issue 671173008: Change some roles to "button" instead of "link" where it'd benefit users of (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@action-link

Patch Set: nit Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/google_chrome_strings.grd

diff --git a/chrome/app/google_chrome_strings.grd b/chrome/app/google_chrome_strings.grd

index 018429230ef95e1a0150ce90f6faf3bd88f11e0d..d17c208bcbd0933ad8c10a80925d953bb1f060e0 100644

--- a/chrome/app/google_chrome_strings.grd

+++ b/chrome/app/google_chrome_strings.grd

@@ -352,7 +352,7 @@ Chrome supports. -->

Use hardware acceleration when available

</message>

- (requires Chrome <ph name="BEGIN_BUTTON"><a is="action-link" id="gpu-mode-reset-restart-button" class="standalone-action-link"></ph>restart<ph name="END_BUTTON"></a></ph>)

+ (requires Chrome <ph name="BEGIN_BUTTON"><a is="action-link" role="button" id="gpu-mode-reset-restart-button" class="standalone-action-link"></ph>restart<ph name="END_BUTTON"></a></ph>)

</message>

Google Chrome cannot read and write to its data directory:

« no previous file with comments | « chrome/app/chromium_strings.grd ('k') | chrome/browser/resources/crashes.html » ('j') | no next file with comments »