Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: chrome/browser/resources/local_discovery/local_discovery.html

Issue 671173008: Change some roles to "button" instead of "link" where it'd benefit users of (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@action-link
Patch Set: nit Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/local_discovery/local_discovery.html
diff --git a/chrome/browser/resources/local_discovery/local_discovery.html b/chrome/browser/resources/local_discovery/local_discovery.html
index 787e30dfa21df43b87e903420e56bd5aadb9d0ed..f0d3cb5ebcd1f5a36733b7c953f21b24c467bda2 100644
--- a/chrome/browser/resources/local_discovery/local_discovery.html
+++ b/chrome/browser/resources/local_discovery/local_discovery.html
@@ -101,7 +101,7 @@
</div>
<header>
- <a is="action-link" id="back-button" hidden>
+ <a is="action-link" id="back-link" hidden>
<span i18n-content="backButton"></span>
</a>
<h1 i18n-content="devicesTitle"></h1>
@@ -113,7 +113,7 @@
<div id="register-login-promo" class="login-promo cloud-print-message"
hidden>
<span i18n-content="registerNeedLogin"></span>
- <a is="action-link" id="register-login-button"
+ <a is="action-link" id="register-login-link"
i18n-content="cloudDevicesLogin"></a>
</div>
<div id="no-printers-message"
@@ -145,13 +145,13 @@
<div id="cloud-devices-login-promo" class="login-promo cloud-print-message"
hidden>
<span i18n-content="cloudDevicesNeedLogin"></span>
- <a is="action-link" id="cloud-devices-login-button"
+ <a is="action-link" id="cloud-devices-login-link"
i18n-content="cloudDevicesLogin"></a>
</div>
<div id="cloud-devices-unavailable"
class="cloud-print-message" hidden>
<span i18n-content="cloudDevicesUnavailable"></span>
- <a is="action-link" id="cloud-devices-retry-button"
+ <a is="action-link" role="button" id="cloud-devices-retry-link"
i18n-content="retryLoadCloudDevices"></a>
</div>
<div id="cloud-devices">

Powered by Google App Engine
This is Rietveld 408576698