Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/local_discovery/local_discovery.html

Issue 671173008: Change some roles to "button" instead of "link" where it'd benefit users of (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@action-link
Patch Set: nit Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/local_discovery/local_discovery.css ('k') | chrome/browser/resources/local_discovery/local_discovery.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE HTML> 1 <!DOCTYPE HTML>
2 <html i18n-values="dir:textdirection"> 2 <html i18n-values="dir:textdirection">
3 <head> 3 <head>
4 <meta charset="utf-8"> 4 <meta charset="utf-8">
5 <title i18n-content="devicesTitle"></title> 5 <title i18n-content="devicesTitle"></title>
6 <link rel="stylesheet" href="chrome://resources/css/chrome_shared.css"> 6 <link rel="stylesheet" href="chrome://resources/css/chrome_shared.css">
7 <link rel="stylesheet" href="chrome://resources/css/overlay.css"> 7 <link rel="stylesheet" href="chrome://resources/css/overlay.css">
8 <link rel="stylesheet" href="chrome://resources/css/spinner.css"> 8 <link rel="stylesheet" href="chrome://resources/css/spinner.css">
9 <link rel="stylesheet" href="local_discovery.css"> 9 <link rel="stylesheet" href="local_discovery.css">
10 10
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 <div i18n-content="addingErrorMessage" id="error-message"></div> 94 <div i18n-content="addingErrorMessage" id="error-message"></div>
95 <div class="button-list"> 95 <div class="button-list">
96 <button id="register-error-exit" i18n-content="ok"></button> 96 <button id="register-error-exit" i18n-content="ok"></button>
97 </div> 97 </div>
98 </div> 98 </div>
99 </div> 99 </div>
100 </div> 100 </div>
101 </div> 101 </div>
102 102
103 <header> 103 <header>
104 <a is="action-link" id="back-button" hidden> 104 <a is="action-link" id="back-link" hidden>
105 <span i18n-content="backButton"></span> 105 <span i18n-content="backButton"></span>
106 </a> 106 </a>
107 <h1 i18n-content="devicesTitle"></h1> 107 <h1 i18n-content="devicesTitle"></h1>
108 </header> 108 </header>
109 109
110 <div class="controls" id="printers"> 110 <div class="controls" id="printers">
111 <h2 i18n-content="availableDevicesTitle"></h2> 111 <h2 i18n-content="availableDevicesTitle"></h2>
112 112
113 <div id="register-login-promo" class="login-promo cloud-print-message" 113 <div id="register-login-promo" class="login-promo cloud-print-message"
114 hidden> 114 hidden>
115 <span i18n-content="registerNeedLogin"></span> 115 <span i18n-content="registerNeedLogin"></span>
116 <a is="action-link" id="register-login-button" 116 <a is="action-link" id="register-login-link"
117 i18n-content="cloudDevicesLogin"></a> 117 i18n-content="cloudDevicesLogin"></a>
118 </div> 118 </div>
119 <div id="no-printers-message" 119 <div id="no-printers-message"
120 class="cloud-print-message" 120 class="cloud-print-message"
121 i18n-content="noPrintersOnNetworkExplanation"> 121 i18n-content="noPrintersOnNetworkExplanation">
122 </div> 122 </div>
123 123
124 <div class="devices" id="register-device-list"></div> 124 <div class="devices" id="register-device-list"></div>
125 125
126 <if expr="not chromeos"> 126 <if expr="not chromeos">
(...skipping 11 matching lines...) Expand all
138 </div> 138 </div>
139 139
140 <div id="my-devices-container"> 140 <div id="my-devices-container">
141 <h2 i18n-content="myDevicesTitle"></h2> 141 <h2 i18n-content="myDevicesTitle"></h2>
142 <div id="cloud-devices-loading" class="cloud-print-message" hidden> 142 <div id="cloud-devices-loading" class="cloud-print-message" hidden>
143 <div class="inline-spinner"> </div> <span i18n-content="loading"></span> 143 <div class="inline-spinner"> </div> <span i18n-content="loading"></span>
144 </div> 144 </div>
145 <div id="cloud-devices-login-promo" class="login-promo cloud-print-message" 145 <div id="cloud-devices-login-promo" class="login-promo cloud-print-message"
146 hidden> 146 hidden>
147 <span i18n-content="cloudDevicesNeedLogin"></span> 147 <span i18n-content="cloudDevicesNeedLogin"></span>
148 <a is="action-link" id="cloud-devices-login-button" 148 <a is="action-link" id="cloud-devices-login-link"
149 i18n-content="cloudDevicesLogin"></a> 149 i18n-content="cloudDevicesLogin"></a>
150 </div> 150 </div>
151 <div id="cloud-devices-unavailable" 151 <div id="cloud-devices-unavailable"
152 class="cloud-print-message" hidden> 152 class="cloud-print-message" hidden>
153 <span i18n-content="cloudDevicesUnavailable"></span> 153 <span i18n-content="cloudDevicesUnavailable"></span>
154 <a is="action-link" id="cloud-devices-retry-button" 154 <a is="action-link" role="button" id="cloud-devices-retry-link"
155 i18n-content="retryLoadCloudDevices"></a> 155 i18n-content="retryLoadCloudDevices"></a>
156 </div> 156 </div>
157 <div id="cloud-devices"> 157 <div id="cloud-devices">
158 158
159 </div> 159 </div>
160 </div> 160 </div>
161 </div> 161 </div>
162 162
163 <script src="chrome://resources/js/i18n_template2.js"></script> 163 <script src="chrome://resources/js/i18n_template2.js"></script>
164 <script src="chrome://resources/js/jstemplate_compiled.js"></script> 164 <script src="chrome://resources/js/jstemplate_compiled.js"></script>
165 </body> 165 </body>
166 </html> 166 </html>
OLDNEW
« no previous file with comments | « chrome/browser/resources/local_discovery/local_discovery.css ('k') | chrome/browser/resources/local_discovery/local_discovery.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698