Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 669953003: Revert of Standardize usage of virtual/override/final in ipc/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
agl
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, mkwst+moarreviews-ipc_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Standardize usage of virtual/override/final in ipc/ (patchset #1 id:1 of https://codereview.chromium.org/645623006/) Reason for revert: Addressing reviewer comments in a followup patch. Original issue's description: > Standardize usage of virtual/override/final in ipc/ > > This patch was automatically generated by applying clang fixit hints > generated by the plugin to the source tree. > > BUG=417463 > TBR=agl@chromium.org > > Committed: https://crrev.com/39be52ebbd6681c7d79ad63e2a0ab028075af0c2 > Cr-Commit-Position: refs/heads/master@{#300481} TBR=agl@chromium.org NOTREECHECKS=true NOTRY=true BUG=417463 Committed: https://crrev.com/f3076af7e0dfc078e65039a0e6faebf9a7628a63 Cr-Commit-Position: refs/heads/master@{#300521}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -250 lines) Patch
M ipc/ipc_channel.h View 1 chunk +2 lines, -1 line 0 comments Download
M ipc/ipc_channel_factory.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M ipc/ipc_channel_posix.h View 3 chunks +16 lines, -14 lines 0 comments Download
M ipc/ipc_channel_posix_unittest.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M ipc/ipc_channel_proxy.h View 3 chunks +6 lines, -6 lines 0 comments Download
M ipc/ipc_channel_proxy_unittest.cc View 8 chunks +14 lines, -14 lines 0 comments Download
M ipc/ipc_channel_unittest.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M ipc/ipc_forwarding_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_fuzzing_tests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_message.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_message_macros.h View 1 chunk +51 lines, -48 lines 0 comments Download
M ipc/ipc_perftest_support.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M ipc/ipc_send_fds_test.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M ipc/ipc_sync_channel.h View 2 chunks +9 lines, -9 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 45 chunks +54 lines, -50 lines 0 comments Download
M ipc/ipc_sync_message.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_sync_message_filter.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ipc/ipc_test_channel_listener.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ipc/ipc_test_sink.h View 1 chunk +8 lines, -8 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.h View 2 chunks +11 lines, -10 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo_host.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo_readers.h View 4 chunks +9 lines, -9 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo_unittest.cc View 11 chunks +26 lines, -20 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ipc/mojo/ipc_mojo_perftest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ipc/sync_socket_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/unix_domain_socket_util_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
Created Revert of Standardize usage of virtual/override/final in ipc/
6 years, 2 months ago (2014-10-21 17:58:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669953003/1
6 years, 2 months ago (2014-10-21 18:00:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 18:03:01 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 18:04:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3076af7e0dfc078e65039a0e6faebf9a7628a63
Cr-Commit-Position: refs/heads/master@{#300521}

Powered by Google App Engine
This is Rietveld 408576698