ipc/ipc_channel_unittest.cc - Issue 669953003: Revert of Standardize usage of virtual/override/final in ipc/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_channel_unittest.cc

Issue 669953003: Revert of Standardize usage of virtual/override/final in ipc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/ipc_channel_unittest.cc

diff --git a/ipc/ipc_channel_unittest.cc b/ipc/ipc_channel_unittest.cc

index 1b28376c935e596f6d563e7e68afdba9efd6a52a..b9d0723d434f5306ca939b36d5651aea74851ba8 100644

--- a/ipc/ipc_channel_unittest.cc

+++ b/ipc/ipc_channel_unittest.cc

@@ -146,9 +146,11 @@

class ChannelListenerWithOnConnectedSend : public IPC::TestChannelListener {

public:

ChannelListenerWithOnConnectedSend() {}

- ~ChannelListenerWithOnConnectedSend() override {}

- void OnChannelConnected(int32 peer_pid) override { SendNextMessage(); }

+ virtual ~ChannelListenerWithOnConnectedSend() {}

+ virtual void OnChannelConnected(int32 peer_pid) override {

+ SendNextMessage();

+ }

};

#if defined(OS_WIN)

« no previous file with comments | « ipc/ipc_channel_proxy_unittest.cc ('k') | ipc/ipc_forwarding_message_filter.h » ('j') | no next file with comments »