Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2769)

Unified Diff: ipc/ipc_sync_channel.h

Issue 669953003: Revert of Standardize usage of virtual/override/final in ipc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_send_fds_test.cc ('k') | ipc/ipc_sync_channel_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_sync_channel.h
diff --git a/ipc/ipc_sync_channel.h b/ipc/ipc_sync_channel.h
index 35934850ed7cbf77b2123612648bf86c65d17544..3f62d2f35600af0747258c1055f49497d7b16f57 100644
--- a/ipc/ipc_sync_channel.h
+++ b/ipc/ipc_sync_channel.h
@@ -91,9 +91,9 @@
const scoped_refptr<base::SingleThreadTaskRunner>& ipc_task_runner,
base::WaitableEvent* shutdown_event);
- ~SyncChannel() override;
-
- bool Send(Message* message) override;
+ virtual ~SyncChannel();
+
+ virtual bool Send(Message* message) override;
// Sets the dispatch group for this channel, to only allow re-entrant dispatch
// of messages to other channels in the same group.
@@ -170,17 +170,17 @@
base::WaitableEventWatcher::EventCallback MakeWaitableEventCallback();
private:
- ~SyncContext() override;
+ virtual ~SyncContext();
// ChannelProxy methods that we override.
// Called on the listener thread.
- void Clear() override;
+ virtual void Clear() override;
// Called on the IPC thread.
- bool OnMessageReceived(const Message& msg) override;
- void OnChannelError() override;
- void OnChannelOpened() override;
- void OnChannelClosed() override;
+ virtual bool OnMessageReceived(const Message& msg) override;
+ virtual void OnChannelError() override;
+ virtual void OnChannelOpened() override;
+ virtual void OnChannelClosed() override;
// Cancels all pending Send calls.
void CancelPendingSends();
« no previous file with comments | « ipc/ipc_send_fds_test.cc ('k') | ipc/ipc_sync_channel_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698