ipc/sync_socket_unittest.cc - Issue 669953003: Revert of Standardize usage of virtual/override/final in ipc/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/sync_socket_unittest.cc

Issue 669953003: Revert of Standardize usage of virtual/override/final in ipc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/sync_socket_unittest.cc

diff --git a/ipc/sync_socket_unittest.cc b/ipc/sync_socket_unittest.cc

index 77ae72d39e3373857a44bbcdf4d32dee455cf355..040dcdc510c0accc91b0a2635e7b5aabd14ba348 100644

--- a/ipc/sync_socket_unittest.cc

+++ b/ipc/sync_socket_unittest.cc

@@ -58,7 +58,7 @@

chan_ = chan;

}

- bool OnMessageReceived(const IPC::Message& msg) override {

+ virtual bool OnMessageReceived(const IPC::Message& msg) override {

if (msg.routing_id() == MSG_ROUTING_CONTROL) {

IPC_BEGIN_MESSAGE_MAP(SyncSocketServerListener, msg)

IPC_MESSAGE_HANDLER(MsgClassSetHandle, OnMsgClassSetHandle)

@@ -129,7 +129,7 @@

chan_ = chan;

}

- bool OnMessageReceived(const IPC::Message& msg) override {

+ virtual bool OnMessageReceived(const IPC::Message& msg) override {

if (msg.routing_id() == MSG_ROUTING_CONTROL) {

IPC_BEGIN_MESSAGE_MAP(SyncSocketClientListener, msg)

IPC_MESSAGE_HANDLER(MsgClassResponse, OnMsgClassResponse)

« no previous file with comments | « ipc/mojo/ipc_mojo_perftest.cc ('k') | ipc/unix_domain_socket_util_unittest.cc » ('j') | no next file with comments »