Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: ipc/mojo/ipc_channel_mojo_readers.h

Issue 669953003: Revert of Standardize usage of virtual/override/final in ipc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/mojo/ipc_channel_mojo_host.cc ('k') | ipc/mojo/ipc_channel_mojo_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/mojo/ipc_channel_mojo_readers.h
diff --git a/ipc/mojo/ipc_channel_mojo_readers.h b/ipc/mojo/ipc_channel_mojo_readers.h
index cadf453c393b24cabc90b376d3bf64871a1c0607..fae62adc7663f14828303019d372e759fba7a8cf 100644
--- a/ipc/mojo/ipc_channel_mojo_readers.h
+++ b/ipc/mojo/ipc_channel_mojo_readers.h
@@ -33,9 +33,9 @@
bool Send(scoped_ptr<Message> message);
// MessagePipeReader implementation
- void OnMessageReceived() override;
- void OnPipeClosed() override;
- void OnPipeError(MojoResult error) override;
+ virtual void OnMessageReceived() override;
+ virtual void OnPipeClosed() override;
+ virtual void OnPipeError(MojoResult error) override;
private:
ChannelMojo* owner_;
@@ -52,8 +52,8 @@
virtual bool Connect();
// MessagePipeReader implementation
- void OnPipeClosed() override;
- void OnPipeError(MojoResult error) override;
+ virtual void OnPipeClosed() override;
+ virtual void OnPipeError(MojoResult error) override;
protected:
ChannelMojo* owner_;
@@ -65,13 +65,13 @@
class ServerControlReader : public ControlReader {
public:
ServerControlReader(mojo::ScopedMessagePipeHandle pipe, ChannelMojo* owner);
- ~ServerControlReader() override;
+ virtual ~ServerControlReader();
// ControlReader override
- bool Connect() override;
+ virtual bool Connect() override;
// MessagePipeReader implementation
- void OnMessageReceived() override;
+ virtual void OnMessageReceived() override;
private:
MojoResult SendHelloRequest();
@@ -88,7 +88,7 @@
ClientControlReader(mojo::ScopedMessagePipeHandle pipe, ChannelMojo* owner);
// MessagePipeReader implementation
- void OnMessageReceived() override;
+ virtual void OnMessageReceived() override;
private:
MojoResult RespondHelloRequest(MojoHandle message_channel);
« no previous file with comments | « ipc/mojo/ipc_channel_mojo_host.cc ('k') | ipc/mojo/ipc_channel_mojo_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698