Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: ipc/ipc_send_fds_test.cc

Issue 669953003: Revert of Standardize usage of virtual/override/final in ipc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_perftest_support.cc ('k') | ipc/ipc_sync_channel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_send_fds_test.cc
diff --git a/ipc/ipc_send_fds_test.cc b/ipc/ipc_send_fds_test.cc
index 332a631068e55e2a355d0c60a7999041afe23ae8..3961fa16e52d73bf234d80ab6167b5c2cd7e5bdd 100644
--- a/ipc/ipc_send_fds_test.cc
+++ b/ipc/ipc_send_fds_test.cc
@@ -33,7 +33,7 @@
class MyChannelDescriptorListenerBase : public IPC::Listener {
public:
- bool OnMessageReceived(const IPC::Message& message) override {
+ virtual bool OnMessageReceived(const IPC::Message& message) override {
PickleIterator iter(message);
base::FileDescriptor descriptor;
@@ -60,10 +60,12 @@
return num_fds_received_ == kNumFDsToSend;
}
- void OnChannelError() override { base::MessageLoop::current()->Quit(); }
+ virtual void OnChannelError() override {
+ base::MessageLoop::current()->Quit();
+ }
protected:
- void HandleFD(int fd) override {
+ virtual void HandleFD(int fd) override {
// Check that we can read from the FD.
char buf;
ssize_t amt_read = read(fd, &buf, 1);
@@ -200,7 +202,9 @@
}
protected:
- void HandleFD(int fd) override { cb_.Run(fd); }
+ virtual void HandleFD(int fd) override {
+ cb_.Run(fd);
+ }
private:
base::Callback<void(int)> cb_;
};
« no previous file with comments | « ipc/ipc_perftest_support.cc ('k') | ipc/ipc_sync_channel.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698