Add <a is="action-link">, a web component extension of <a> for in-page actions.

Add <a is="action-link">, a web component extension of <a> for in-page actions.

Has the benefit of looking a lot like an <a> tag naturally without a whole
bunch of CSS resetting. Also lacks the extra context menu options
(e.g. "Copy link location...") like <a href> has.

Replaces <button class="link-button">, which has always been odd to me.

BUG=399376
R=dmazzoni@chromium.org,aboxhall@chromium.org
TBR=fukino@chromium.org

Committed: https://crrev.com/60e00c0382e70dc2191dd7d20cfbff146de64afc
Cr-Commit-Position: refs/heads/master@{#301040}

[Dan Beam, 2014-10-22 06:30:17]

Patchset #2 (id:20001) has been deleted

[dmazzoni, 2014-10-22 06:37:15]

dmazzoni@chromium.org changed reviewers:
+ aboxhall@chromium.org

[dmazzoni, 2014-10-22 06:37:16]

+aboxhall - she knows components better than I do.

Yay for components!

Are these focusable by default like links are? Does VoiceOver call this a link?
Do we need to add role=link and/or tabIndex=0?

[Dan Beam, 2014-10-22 19:17:29]

On 2014/10/22 06:37:16, dmazzoni wrote:
> +aboxhall - she knows components better than I do.
> 
> Yay for components!
> 
> Are these focusable by default like links are? Does VoiceOver call this a
link?
> Do we need to add role=link and/or tabIndex=0?

needed tabIndex=0 (links with [href] need this) but not role=link (inherited
correctly)

[Dan Beam, 2014-10-22 19:24:46]

On 2014/10/22 19:17:29, Dan Beam wrote:
> On 2014/10/22 06:37:16, dmazzoni wrote:
> > +aboxhall - she knows components better than I do.
> > 
> > Yay for components!
> > 
> > Are these focusable by default like links are? Does VoiceOver call this a
> link?
> > Do we need to add role=link and/or tabIndex=0?
> 
> needed tabIndex=0 (links with [href] need this) but not role=link (inherited
> correctly)

links without** [href] (aren't focusable by default)

[aboxhall, 2014-10-22 19:34:29]

On 2014/10/22 19:24:46, Dan Beam wrote:
> On 2014/10/22 19:17:29, Dan Beam wrote:
> > On 2014/10/22 06:37:16, dmazzoni wrote:
> > > +aboxhall - she knows components better than I do.
> > > 
> > > Yay for components!
> > > 
> > > Are these focusable by default like links are? Does VoiceOver call this a
> > link?
> > > Do we need to add role=link and/or tabIndex=0?
> > 
> > needed tabIndex=0 (links with [href] need this) but not role=link (inherited
> > correctly)
> 
> links without** [href] (aren't focusable by default)

Oh, I've always liked <button class="link-button">. These elements usually
aren't actually links, IIRC - they're actions, i.e. more like a button than a
link. Why do we want to make them links?

[Dan Beam, 2014-10-22 19:48:08]

On 2014/10/22 19:34:29, aboxhall wrote:
> On 2014/10/22 19:24:46, Dan Beam wrote:
> > On 2014/10/22 19:17:29, Dan Beam wrote:
> > > On 2014/10/22 06:37:16, dmazzoni wrote:
> > > > +aboxhall - she knows components better than I do.
> > > > 
> > > > Yay for components!
> > > > 
> > > > Are these focusable by default like links are? Does VoiceOver call this
a
> > > link?
> > > > Do we need to add role=link and/or tabIndex=0?
> > > 
> > > needed tabIndex=0 (links with [href] need this) but not role=link
(inherited
> > > correctly)
> > 
> > links without** [href] (aren't focusable by default)
> 
> Oh, I've always liked <button class="link-button">. These elements usually
> aren't actually links, IIRC - they're actions, i.e. more like a button than a
> link. Why do we want to make them links?

Because we took a <button> and made it look like a link with slightly different
behavior.  Why not just start with a... link?  Did you read action_link.js?

[aboxhall, 2014-10-22 19:59:41]

On 2014/10/22 19:48:08, Dan Beam wrote:
> On 2014/10/22 19:34:29, aboxhall wrote:
> > On 2014/10/22 19:24:46, Dan Beam wrote:
> > > On 2014/10/22 19:17:29, Dan Beam wrote:
> > > > On 2014/10/22 06:37:16, dmazzoni wrote:
> > > > > +aboxhall - she knows components better than I do.
> > > > > 
> > > > > Yay for components!
> > > > > 
> > > > > Are these focusable by default like links are? Does VoiceOver call
this
> a
> > > > link?
> > > > > Do we need to add role=link and/or tabIndex=0?
> > > > 
> > > > needed tabIndex=0 (links with [href] need this) but not role=link
> (inherited
> > > > correctly)
> > > 
> > > links without** [href] (aren't focusable by default)
> > 
> > Oh, I've always liked <button class="link-button">. These elements usually
> > aren't actually links, IIRC - they're actions, i.e. more like a button than
a
> > link. Why do we want to make them links?
> 
> Because we took a <button> and made it look like a link with slightly
different
> behavior.  Why not just start with a... link?  Did you read action_link.js?

I did, yeah.

I have suggested people use <button class="link-button"> in the past because I
think making something which triggers an action rather than a navigation a link
just so that it has a certain visual style has the potential to be confusing, so
I'm a bit dismayed to see things going in the other direction. Imagine, for
example, hearing "Restart chrome, link", and clicking it expecting you might be
redirected to a page which will give you the option to restart chrome, or some
information about why chrome needs to be restarted, only to have the whole
browser stop responding and having to figure out from context what happened. I
think having a button indicates more clearly that this will perform an action
rather than a navigation. (Obviously a similar thing can happen to a sighted
user, but they will have more context, e.g. the lack of URL for the link, the
fact that the browser visually disappears and, where appropriate, the dock icon
starts bouncing, etc.)

That said, this certainly doesn't apply to all the uses of <a is="action-link">
(which I otherwise think is cool btw) in this change, so I'm going through and
annotating which I think should stay as buttons.

[Dan Beam, 2014-10-22 20:11:18]

On 2014/10/22 19:59:41, aboxhall wrote:
> On 2014/10/22 19:48:08, Dan Beam wrote:
> > On 2014/10/22 19:34:29, aboxhall wrote:
> > > On 2014/10/22 19:24:46, Dan Beam wrote:
> > > > On 2014/10/22 19:17:29, Dan Beam wrote:
> > > > > On 2014/10/22 06:37:16, dmazzoni wrote:
> > > > > > +aboxhall - she knows components better than I do.
> > > > > > 
> > > > > > Yay for components!
> > > > > > 
> > > > > > Are these focusable by default like links are? Does VoiceOver call
> this
> > a
> > > > > link?
> > > > > > Do we need to add role=link and/or tabIndex=0?
> > > > > 
> > > > > needed tabIndex=0 (links with [href] need this) but not role=link
> > (inherited
> > > > > correctly)
> > > > 
> > > > links without** [href] (aren't focusable by default)
> > > 
> > > Oh, I've always liked <button class="link-button">. These elements usually
> > > aren't actually links, IIRC - they're actions, i.e. more like a button
than
> a
> > > link. Why do we want to make them links?
> > 
> > Because we took a <button> and made it look like a link with slightly
> different
> > behavior.  Why not just start with a... link?  Did you read action_link.js?
> 
> I did, yeah.
> 
> I have suggested people use <button class="link-button"> in the past because I
> think making something which triggers an action rather than a navigation a
link
> just so that it has a certain visual style has the potential to be confusing,
so
> I'm a bit dismayed to see things going in the other direction. Imagine, for
> example, hearing "Restart chrome, link", and clicking it expecting you might
be
> redirected to a page which will give you the option to restart chrome, or some
> information about why chrome needs to be restarted, only to have the whole
> browser stop responding and having to figure out from context what happened. I
> think having a button indicates more clearly that this will perform an action
> rather than a navigation. (Obviously a similar thing can happen to a sighted
> user, but they will have more context, e.g. the lack of URL for the link, the
> fact that the browser visually disappears and, where appropriate, the dock
icon
> starts bouncing, etc.)
> 
> That said, this certainly doesn't apply to all the uses of <a
is="action-link">
> (which I otherwise think is cool btw) in this change, so I'm going through and
> annotating which I think should stay as buttons.

That seems fine.  I've always thought that a restart link is a bad idea, yes, as
it's not really navigating (in the page or not).

[aboxhall, 2014-10-22 21:33:32]

Ok, I didn't find too many instances where it should really be a button rather
than a link after all.

However, I did notice some patterns which we might want to keep in mind:
- Using action-link for an actual action - AFAICT this is really just used for
those scary restart "links" which we should probably do something better with
anyway.
- Using action-link to pop up a dialog. This makes sense, although we're not
consistent about it (there are several cases in settings where we're using a
button to pop up a dialog). Obviously we should also make sure we're following
the usual dialog best practices.
- Using action-link to expand/collapse a section. This is less clear, as I'll
explain below.
- Using action-link to open a new tab. No problem.
- Using action-link to navigate to some piece of external UI, e.g. an OS file
manager or OS level settings. These are borderline to me, although in some cases
the element is cloned several times and used in different ways (specifically in
the case of the Cloud Print settings dialog), so it's not always clear that we
could use a different pattern depending on what will be opened. Anyway, this is
the only one I think really needs a bit more thought.

In general, I found this heuristic useful: does it behave like a link in that
either "back" will undo whatever action it does (dialogs), or in that it opens a
new tab? In the case of expanding sections this breaks down - "back" may do
something unpredictable in this case, so we might want to do something similar
to what we do with dialogs and push some history state so that we don't break
the metaphor?

https://codereview.chromium.org/668983004/diff/100001/chrome/app/chromium_str...
File chrome/app/chromium_strings.grd (right):

https://codereview.chromium.org/668983004/diff/100001/chrome/app/chromium_str...
chrome/app/chromium_strings.grd:432: (requires Chromium <ph
name="BEGIN_BUTTON">&lt;a is="action-link" id="gpu-mode-reset-restart-button"
class="standalone-action-link"&gt;</ph>restart<ph
name="END_BUTTON">&lt;/a&gt;</ph>)
I think this should remain a button (here and in google_chrome_strings).

https://codereview.chromium.org/668983004/diff/100001/chrome/browser/resource...
File chrome/browser/resources/crashes.html (right):

https://codereview.chromium.org/668983004/diff/100001/chrome/browser/resource...
chrome/browser/resources/crashes.html:17: <a is="action-link" id="uploadCrashes"
Likewise: AFAICT this doesn't cause any navigation, so I think making it a link
is confusing.

https://codereview.chromium.org/668983004/diff/100001/chrome/browser/resource...
File chrome/browser/resources/downloads/downloads.js (right):

https://codereview.chromium.org/668983004/diff/100001/chrome/browser/resource...
chrome/browser/resources/downloads/downloads.js:58: function createLink(onclick,
opt_text) {
Perhaps this should be renamed createActionLink, to avoid confusion?

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
File chrome/browser/resources/extensions/extensions.html (left):

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
chrome/browser/resources/extensions/extensions.html:115: <a target="_blank"
class="more-extensions-link"
Why remove target="_blank" here and below? And why make this one an action-link:
it seems like it's just a plain link?

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
chrome/browser/resources/extensions/extensions.html:228: <div
class="terminated-reload-link link-button"
Wow, this never made any sense at all...

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
File chrome/browser/resources/extensions/extensions.html (right):

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
chrome/browser/resources/extensions/extensions.html:148: <a is="action-link"
class="reload-link"
This seems like an action (i.e. button) rather than a link to me.

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
chrome/browser/resources/extensions/extensions.html:226: <a is="action-link"
class="terminated-reload-link"
This seems like an action to me.

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
chrome/browser/resources/extensions/extensions.html:228: <a
class="corrupted-repair-button"
I can't figure out what this does...

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
File
chrome/browser/resources/hotword_audio_verification/steps/audio_history_step.html
(left):

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
chrome/browser/resources/hotword_audio_verification/steps/audio_history_step.html:18:
<a href="#" class="link-button">LEARN MORE</a>
This also never made sense.

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
File chrome/browser/resources/local_discovery/local_discovery.html (right):

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
chrome/browser/resources/local_discovery/local_discovery.html:37: <a
is="action-link" id="register-overlay-login-button"
Probably outside of scope here, but this ID is a little misleading now.

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
chrome/browser/resources/local_discovery/local_discovery.html:154: <a
is="action-link" id="cloud-devices-retry-button"
This looks like an action (button) to me.

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
File chrome/browser/resources/ntp4/new_tab.js (right):

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
chrome/browser/resources/ntp4/new_tab.js:465: var link =
linksBin.ownerDocument.createElement('a', 'action-link');
This is a clear improvement!

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
File chrome/browser/resources/options/browser_options.html (right):

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
chrome/browser/resources/options/browser_options.html:397: <span></span><a
is="action-link"
This is a surprise restart button! Definitely should be a button, should
probably even look like a button.

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
File chrome/browser/resources/print_preview/search/destination_list.html
(right):

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
chrome/browser/resources/print_preview/search/destination_list.html:4: <a
is="action-link" class="action-link" hidden></a>
Not sure about this - it may or may not pop open a system dialog. What do you
think?

https://codereview.chromium.org/668983004/diff/120001/ui/webui/resources/css/...
File ui/webui/resources/css/widgets.css (right):

https://codereview.chromium.org/668983004/diff/120001/ui/webui/resources/css/...
ui/webui/resources/css/widgets.css:252: /* Action links
***************************************************************/
Theoretically you could poke the style into the shadow root of the element in
its created callback, however since you don't need a shadow root otherwise
that's probably unnecessarily expensive. Just a thought :)

https://codereview.chromium.org/668983004/diff/120001/ui/webui/resources/js/a...
File ui/webui/resources/js/action_link.js (right):

https://codereview.chromium.org/668983004/diff/120001/ui/webui/resources/js/a...
ui/webui/resources/js/action_link.js:45: e.preventDefault();
I don't think you need this (though I could be wrong) - try without? (I think
using is= overrides all the existing event handling.)

[Dan Beam, 2014-10-23 03:01:54]

Patchset #8 (id:160001) has been deleted

[Dan Beam, 2014-10-23 03:05:44]

I agree with your UI concerns.  In general this CL is meant to swap the
implementation transparently to users and to avoid mass refactors like this
again by using web components (a better way to encapsulate).  BUT, I'm not sure
exactly how AT users would react if lots of "button"s changed to "link". 
dmazzoni@ was fine with changing role="link" everywhere, but I can see how this
might change the experience.

I've filed crbug.com/426308 with screenshots and descriptions of the odd places
we should probably be showing buttons instead of links, but expect pushback from
designers (as I've already gotten some).

That said: are we OK with much of these "buttons" change to role="link"?

https://codereview.chromium.org/668983004/diff/100001/chrome/app/chromium_str...
File chrome/app/chromium_strings.grd (right):

https://codereview.chromium.org/668983004/diff/100001/chrome/app/chromium_str...
chrome/app/chromium_strings.grd:432: (requires Chromium <ph
name="BEGIN_BUTTON">&lt;a is="action-link" id="gpu-mode-reset-restart-button"
class="standalone-action-link"&gt;</ph>restart<ph
name="END_BUTTON">&lt;/a&gt;</ph>)
On 2014/10/22 21:33:30, aboxhall wrote:
> I think this should remain a button (here and in google_chrome_strings).

note: this is already a link in appearance

https://codereview.chromium.org/668983004/diff/100001/chrome/browser/resource...
File chrome/browser/resources/downloads/downloads.js (right):

https://codereview.chromium.org/668983004/diff/100001/chrome/browser/resource...
chrome/browser/resources/downloads/downloads.js:58: function createLink(onclick,
opt_text) {
On 2014/10/22 21:33:31, aboxhall wrote:
> Perhaps this should be renamed createActionLink, to avoid confusion?

Done.

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
File chrome/browser/resources/extensions/extensions.html (left):

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
chrome/browser/resources/extensions/extensions.html:115: <a target="_blank"
class="more-extensions-link"
On 2014/10/22 21:33:31, aboxhall wrote:
> Why remove target="_blank" here and below? And why make this one an
action-link:
> it seems like it's just a plain link?

whoops. Done.

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
chrome/browser/resources/extensions/extensions.html:228: <div
class="terminated-reload-link link-button"
On 2014/10/22 21:33:31, aboxhall wrote:
> Wow, this never made any sense at all...

yeah, these probably worked via mouse click only

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
File chrome/browser/resources/extensions/extensions.html (right):

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
chrome/browser/resources/extensions/extensions.html:228: <a
class="corrupted-repair-button"
On 2014/10/22 21:33:31, aboxhall wrote:
> I can't figure out what this does...

Done. (added is="action-link")

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
File chrome/browser/resources/local_discovery/local_discovery.html (right):

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
chrome/browser/resources/local_discovery/local_discovery.html:37: <a
is="action-link" id="register-overlay-login-button"
On 2014/10/22 21:33:31, aboxhall wrote:
> Probably outside of scope here, but this ID is a little misleading now.

Acknowledged.

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
File chrome/browser/resources/ntp4/new_tab.js (right):

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
chrome/browser/resources/ntp4/new_tab.js:465: var link =
linksBin.ownerDocument.createElement('a', 'action-link');
On 2014/10/22 21:33:31, aboxhall wrote:
> This is a clear improvement!

yay!

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
File chrome/browser/resources/options/browser_options.html (right):

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
chrome/browser/resources/options/browser_options.html:397: <span></span><a
is="action-link"
On 2014/10/22 21:33:31, aboxhall wrote:
> This is a surprise restart button! Definitely should be a button, should
> probably even look like a button.

while I agree with you, see the IMs with glen@ I sent you.

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
File chrome/browser/resources/print_preview/search/destination_list.html
(right):

https://codereview.chromium.org/668983004/diff/120001/chrome/browser/resource...
chrome/browser/resources/print_preview/search/destination_list.html:4: <a
is="action-link" class="action-link" hidden></a>
On 2014/10/22 21:33:31, aboxhall wrote:
> Not sure about this - it may or may not pop open a system dialog. What do you
> think?

i think you still need to go "back" to Chrome in the window management, so it's
similar enough for me

https://codereview.chromium.org/668983004/diff/120001/ui/webui/resources/css/...
File ui/webui/resources/css/widgets.css (right):

https://codereview.chromium.org/668983004/diff/120001/ui/webui/resources/css/...
ui/webui/resources/css/widgets.css:252: /* Action links
***************************************************************/
On 2014/10/22 21:33:31, aboxhall wrote:
> Theoretically you could poke the style into the shadow root of the element in
> its created callback, however since you don't need a shadow root otherwise
> that's probably unnecessarily expensive. Just a thought :)

right, saving until there's more fancy stuff we need to do (that otherwise
requires a shadow root)

https://codereview.chromium.org/668983004/diff/120001/ui/webui/resources/js/a...
File ui/webui/resources/js/action_link.js (right):

https://codereview.chromium.org/668983004/diff/120001/ui/webui/resources/js/a...
ui/webui/resources/js/action_link.js:45: e.preventDefault();
On 2014/10/22 21:33:32, aboxhall wrote:
> I don't think you need this (though I could be wrong) - try without? (I think
> using is= overrides all the existing event handling.)

Done. (sometimes in code we use e.defaultPrevented to ignore some events, but
let's try without it as there's really no default action to prevent...)

maybe we could have an

  /** Override to do something */
  action: function() {},

and then in the action listeners:

  this.addEventListener('click', this.action.bind(this));
  this.addEventListener('keydown', function() {
    if (e.keyIdentifier == 'Enter') this.action(e);
  });

and callers could override

  $('some-link-id').action = function(e) { ... };


however, it's really not too different than:

  $('some-link-id').onclick = function(e) { ... };

with a hell of a lot more code churn :/

[Dan Beam, 2014-10-23 03:06:10]

dbeam@chromium.org changed reviewers:
- estade@chromium.org

[aboxhall, 2014-10-23 21:41:05]

lgtm

https://codereview.chromium.org/668983004/diff/100001/chrome/app/chromium_str...
File chrome/app/chromium_strings.grd (right):

https://codereview.chromium.org/668983004/diff/100001/chrome/app/chromium_str...
chrome/app/chromium_strings.grd:432: (requires Chromium <ph
name="BEGIN_BUTTON">&lt;a is="action-link" id="gpu-mode-reset-restart-button"
class="standalone-action-link"&gt;</ph>restart<ph
name="END_BUTTON">&lt;/a&gt;</ph>)
On 2014/10/23 03:05:43, Dan Beam wrote:
> On 2014/10/22 21:33:30, aboxhall wrote:
> > I think this should remain a button (here and in google_chrome_strings).
> 
> note: this is already a link in appearance

Right, but it could stay as a button-that-looks-like-a-link. In the world where
we ran around adding role=link to things instead of this (better) solution, I
think we'd want to leave role=link off this one.

However, that can be a discussion for another day.

https://codereview.chromium.org/668983004/diff/120001/ui/webui/resources/js/a...
File ui/webui/resources/js/action_link.js (right):

https://codereview.chromium.org/668983004/diff/120001/ui/webui/resources/js/a...
ui/webui/resources/js/action_link.js:45: e.preventDefault();
On 2014/10/23 03:05:44, Dan Beam wrote:
> On 2014/10/22 21:33:32, aboxhall wrote:
> > I don't think you need this (though I could be wrong) - try without? (I
think
> > using is= overrides all the existing event handling.)
> 
> Done. (sometimes in code we use e.defaultPrevented to ignore some events, but
> let's try without it as there's really no default action to prevent...)
> 
> maybe we could have an
> 
>   /** Override to do something */
>   action: function() {},
> 
> and then in the action listeners:
> 
>   this.addEventListener('click', this.action.bind(this));
>   this.addEventListener('keydown', function() {
>     if (e.keyIdentifier == 'Enter') this.action(e);
>   });
> 
> and callers could override
> 
>   $('some-link-id').action = function(e) { ... };
> 
> 
> however, it's really not too different than:
> 
>   $('some-link-id').onclick = function(e) { ... };
> 
> with a hell of a lot more code churn :/

Agreed, I think keeping the current (click) behaviour makes sense, especially as
it follows the standard 'simulated click' behaviour of plain links.

[Dan Beam, 2014-10-24 00:54:01]

ping dmazzoni@

[Dan Beam, 2014-10-24 01:08:06]

from dmazzoni@ on chat:

"""
I've been following it, if she's happy then lgtm too
"""

[Dan Beam, 2014-10-24 01:11:39]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2014-10-24 01:11:49]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2014-10-24 01:14:55]

dbeam@chromium.org changed reviewers:
+ fukino@chromium.org

[Dan Beam, 2014-10-24 01:14:56]

TBR=fukino@ for trivial ui/file_manager CSS change (I don't think the
file_manager ever used .link-button).

[Dan Beam, 2014-10-24 01:15:04]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-10-24 01:16:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/668983004/220001

[fukino, 2014-10-24 01:38:51]

On 2014/10/24 01:14:56, Dan Beam wrote:
> TBR=fukino@ for trivial ui/file_manager CSS change (I don't think the
> file_manager ever used .link-button).

lgtm, thank you!

[commit-bot: I haz the power, 2014-10-24 01:40:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 01:40:16]

Try jobs failed on following builders:
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Dan Beam, 2014-10-24 01:43:20]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-10-24 01:44:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/668983004/150059

[commit-bot: I haz the power, 2014-10-24 01:59:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 01:59:44]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2014-10-24 02:14:13]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-10-24 02:15:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/668983004/150059

[commit-bot: I haz the power, 2014-10-24 03:52:16]

Committed patchset #11 (id:150059)

[commit-bot: I haz the power, 2014-10-24 03:52:57]

Patchset 11 (id:??) landed as
https://crrev.com/60e00c0382e70dc2191dd7d20cfbff146de64afc
Cr-Commit-Position: refs/heads/master@{#301040}