chrome/browser/resources/options/controlled_setting.js - Issue 668983004: Add <a is="action-link">, a web component extension of <a> for in-page actions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/controlled_setting.js

Issue 668983004: Add <a is="action-link">, a web component extension of <a> for in-page actions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/clear_browser_data_overlay.js ('k') | chrome/browser/resources/options/font_settings.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/controlled_setting.js

diff --git a/chrome/browser/resources/options/controlled_setting.js b/chrome/browser/resources/options/controlled_setting.js

index 652af10613ac31aedb53de81f9b35d7dfe1678c1..96a023ee1f37c7f9e963b36ed618759300a7fbdc 100644

--- a/chrome/browser/resources/options/controlled_setting.js

+++ b/chrome/browser/resources/options/controlled_setting.js

@@ -145,8 +145,7 @@ cr.define('options', function() {

if (this.controlledBy == 'hasRecommendation' && this.resetHandler_ &&

!this.readOnly) {

var container = document.createElement('div');

- var action = document.createElement('button');

- action.classList.add('link-button');

+ var action = document.createElement('a', 'action-link');

action.classList.add('controlled-setting-bubble-action');

action.textContent =

loadTimeData.getString('controlledSettingFollowRecommendation');