Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/browser/resources/options/clear_browser_data_overlay.js

Issue 668983004: Add <a is="action-link">, a web component extension of <a> for in-page actions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/clear_browser_data_overlay.js
diff --git a/chrome/browser/resources/options/clear_browser_data_overlay.js b/chrome/browser/resources/options/clear_browser_data_overlay.js
index 4684943bcde4219eb236b60dc775a6eaa117dad2..b3886bd0fb0f5f4d2dba212c498b72de0656f560 100644
--- a/chrome/browser/resources/options/clear_browser_data_overlay.js
+++ b/chrome/browser/resources/options/clear_browser_data_overlay.js
@@ -108,22 +108,21 @@ cr.define('options', function() {
loadTimeData.getString('contentSettingsAndSearchEnginesRemain')
.split(/([|#])/);
for (var i = 0; i < footerFragments.length;) {
- var buttonId = '';
+ var linkId = '';
if (i + 2 < footerFragments.length) {
if (footerFragments[i] == '|' && footerFragments[i + 2] == '|') {
- buttonId = 'open-content-settings-from-clear-browsing-data';
+ linkId = 'open-content-settings-from-clear-browsing-data';
} else if (footerFragments[i] == '#' &&
footerFragments[i + 2] == '#') {
- buttonId = 'open-search-engines-from-clear-browsing-data';
+ linkId = 'open-search-engines-from-clear-browsing-data';
}
}
- if (buttonId != '') {
- var button = document.createElement('button');
- button.id = buttonId;
- button.className = 'link-button';
- button.textContent = footerFragments[i + 1];
- footer.appendChild(button);
+ if (linkId) {
+ var link = document.createElement('a', 'action-link');
+ link.id = linkId;
+ link.textContent = footerFragments[i + 1];
+ footer.appendChild(link);
i += 3;
} else {
var span = document.createElement('span');

Powered by Google App Engine
This is Rietveld 408576698