Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6001)

Unified Diff: chrome/browser/resources/options/browser_options.html

Issue 668983004: Add <a is="action-link">, a web component extension of <a> for in-page actions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/browser_options.html
diff --git a/chrome/browser/resources/options/browser_options.html b/chrome/browser/resources/options/browser_options.html
index ff5035848cca7b0b5be653e82e437eac43a00bc6..8d9e42df8cae2f9954385d17a38ef32a2be888e1 100644
--- a/chrome/browser/resources/options/browser_options.html
+++ b/chrome/browser/resources/options/browser_options.html
@@ -73,8 +73,8 @@
<span id="home-page-ntp" class="home-page-label"
i18n-content="homePageNtp"></span>
<span id="home-page-url" class="home-page-label"></span>
- <button id="change-home-page" class="link-button"
- i18n-content="changeHomePage"></button>
+ <a is="action-link" id="change-home-page" i18n-content="changeHomePage">
+ </a>
<div id="extension-controlled-container"></div>
</div>
</div>
@@ -394,8 +394,8 @@
</label>
<span id="metrics-reporting-reset-restart">
<!-- Text filled by JavaScript -->
- <span></span><button class=
- "link-button standalone-link-button"></button><span></span>
+ <span></span><a is="action-link"
+ class="standalone-action-link"></a><span></span>
</span>
</if>
</div>
@@ -479,9 +479,8 @@
</span>
</span>
</label>
- <button id="autofill-settings" class="link-button"
- i18n-content="manageAutofillSettings">
- </button>
+ <a is="action-link" id="autofill-settings"
+ i18n-content="manageAutofillSettings"></a>
</div>
<div class="checkbox controlled-setting-with-label">
<label>
@@ -494,8 +493,8 @@
pref="profile.password_manager_enabled"></span>
</span>
</label>
- <button id="manage-passwords" class="link-button"
- i18n-content="managePasswords"></button>
+ <a is="action-link" id="manage-passwords" i18n-content="managePasswords">
+ </a>
</div>
<if expr="is_macosx">
<div id="mac-passwords-warning" i18n-content="macPasswordsWarning" hidden>
@@ -603,8 +602,8 @@
</span>
</span>
</label>
- <button id="manage-languages" class="link-button"
- i18n-content="manageLanguages"></button>
+ <a is="action-link" id="manage-languages" i18n-content="manageLanguages">
+ </a>
</div>
</section>
<section id="downloads-section">
@@ -929,8 +928,7 @@
</div> <!-- advanced-settings-container -->
</div> <!-- advanced-settings -->
<footer>
- <button id="advanced-settings-expander" class="link-button"
- i18n-content="showAdvancedSettings">
- </button>
+ <a is="action-link" id="advanced-settings-expander"
+ i18n-content="showAdvancedSettings"></a>
</footer>
</div>
« no previous file with comments | « chrome/browser/resources/options/browser_options.css ('k') | chrome/browser/resources/options/chromeos/keyboard_overlay.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698