Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/extensions/extensions.html

Issue 668983004: Add <a is="action-link">, a web component extension of <a> for in-page actions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/extensions/extensions.css ('k') | chrome/browser/resources/extensions/extensions.js » ('j') | chrome/browser/resources/hotword_audio_verification/steps/audio_history_step.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html i18n-values="dir:textdirection;" class="loading"> 2 <html i18n-values="dir:textdirection;" class="loading">
3 <head> 3 <head>
4 <meta charset="utf-8"> 4 <meta charset="utf-8">
5 5
6 <link rel="stylesheet" href="extensions.css"> 6 <link rel="stylesheet" href="extensions.css">
7 <link rel="stylesheet" href="extension_commands_overlay.css"> 7 <link rel="stylesheet" href="extension_commands_overlay.css">
8 <link rel="stylesheet" href="extension_error.css"> 8 <link rel="stylesheet" href="extension_error.css">
9 <link rel="stylesheet" href="extension_error_overlay.css"> 9 <link rel="stylesheet" href="extension_error_overlay.css">
10 <link rel="stylesheet" href="extension_load_error.css"> 10 <link rel="stylesheet" href="extension_load_error.css">
11 <link rel="stylesheet" href="extension_options_overlay.css"> 11 <link rel="stylesheet" href="extension_options_overlay.css">
12 <link rel="stylesheet" href="pack_extension_overlay.css"> 12 <link rel="stylesheet" href="pack_extension_overlay.css">
13 <link rel="stylesheet" href="chrome://resources/css/alert_overlay.css"> 13 <link rel="stylesheet" href="chrome://resources/css/alert_overlay.css">
14 <link rel="stylesheet" href="chrome://resources/css/chrome_shared.css"> 14 <link rel="stylesheet" href="chrome://resources/css/chrome_shared.css">
15 <link rel="stylesheet" href="chrome://resources/css/overlay.css"> 15 <link rel="stylesheet" href="chrome://resources/css/overlay.css">
16 <link rel="stylesheet" href="chrome://resources/css/trash.css"> 16 <link rel="stylesheet" href="chrome://resources/css/trash.css">
17 <link rel="stylesheet" href="../uber/uber_shared.css"> 17 <link rel="stylesheet" href="../uber/uber_shared.css">
18 18
19 <script src="chrome://resources/js/action_link.js"></script>
19 <script src="chrome://resources/js/cr.js"></script> 20 <script src="chrome://resources/js/cr.js"></script>
20 <script src="chrome://resources/js/load_time_data.js"></script> 21 <script src="chrome://resources/js/load_time_data.js"></script>
21 <script src="chrome://resources/js/util.js"></script> 22 <script src="chrome://resources/js/util.js"></script>
22 <script src="chrome://resources/js/cr/ui.js"></script> 23 <script src="chrome://resources/js/cr/ui.js"></script>
23 <script src="chrome://resources/js/cr/ui/alert_overlay.js"></script> 24 <script src="chrome://resources/js/cr/ui/alert_overlay.js"></script>
24 <script src="chrome://resources/js/cr/ui/drag_wrapper.js"></script> 25 <script src="chrome://resources/js/cr/ui/drag_wrapper.js"></script>
25 <script src="chrome://resources/js/cr/ui/focus_manager.js"></script> 26 <script src="chrome://resources/js/cr/ui/focus_manager.js"></script>
26 <script src="chrome://resources/js/cr/ui/focus_outline_manager.js"></script> 27 <script src="chrome://resources/js/cr/ui/focus_outline_manager.js"></script>
27 <script src="chrome://resources/js/cr/ui/overlay.js"></script> 28 <script src="chrome://resources/js/cr/ui/overlay.js"></script>
28 29
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 <include src="extension_load_error.html"> 106 <include src="extension_load_error.html">
106 <div id="extension-settings-list" class="empty-extension-list"></div> 107 <div id="extension-settings-list" class="empty-extension-list"></div>
107 <div id="no-extensions"> 108 <div id="no-extensions">
108 <span id="no-extensions-message" 109 <span id="no-extensions-message"
109 i18n-content="extensionSettingsNoExtensions"></span> 110 i18n-content="extensionSettingsNoExtensions"></span>
110 <span id="suggest-gallery" class="more-extensions-link" 111 <span id="suggest-gallery" class="more-extensions-link"
111 i18n-values=".innerHTML:extensionSettingsSuggestGallery"> 112 i18n-values=".innerHTML:extensionSettingsSuggestGallery">
112 </span> 113 </span>
113 </div> 114 </div>
114 <div id="footer-section"> 115 <div id="footer-section">
115 <a target="_blank" class="more-extensions-link" 116 <a is="action-link" class="more-extensions-link"
aboxhall 2014/10/22 21:33:31 Why remove target="_blank" here and below? And why
Dan Beam 2014/10/23 03:05:44 whoops. Done.
116 i18n-values="href:extensionSettingsGetMoreExtensionsUrl" 117 i18n-values="href:extensionSettingsGetMoreExtensionsUrl"
117 i18n-content="extensionSettingsGetMoreExtensions"></a> 118 i18n-content="extensionSettingsGetMoreExtensions"></a>
118 <a target="_blank" hidden 119 <a is="action-link" class="extension-commands-config"
119 class="extension-commands-config" 120 i18n-content="extensionSettingsCommandsLink" hidden></a>
120 i18n-content="extensionSettingsCommandsLink"
121 href="#"></a>
122 </div> 121 </div>
123 </div> 122 </div>
124 123
125 <span id="font-measuring-div"></span> 124 <span id="font-measuring-div"></span>
126 125
127 <div id="template-collection" hidden> 126 <div id="template-collection" hidden>
128 127
129 <div class="extension-list-item-wrapper"> 128 <div class="extension-list-item-wrapper">
130 <div class="extension-list-item"> 129 <div class="extension-list-item">
131 <div class="extension-details"> 130 <div class="extension-details">
132 <div> 131 <div>
133 <span class="extension-title"></span> 132 <span class="extension-title"></span>
134 <span class="extension-version"></span> 133 <span class="extension-version"></span>
135 </div> 134 </div>
136 <p class="corrupt-install-message" 135 <p class="corrupt-install-message"
137 i18n-content="extensionSettingsCorruptInstall" hidden></p> 136 i18n-content="extensionSettingsCorruptInstall" hidden></p>
138 <p class="extension-description"></p> 137 <p class="extension-description"></p>
139 <div class="action-links"> 138 <div class="action-links">
140 <button class="permissions-link link-button" 139 <a is="action-link" class="permissions-link"
141 i18n-content="extensionSettingsPermissions"></button> 140 i18n-content="extensionSettingsPermissions"></a>
142 <button class="options-button link-button" 141 <a is="action-link" class="options-button"
143 i18n-content="extensionSettingsOptions" hidden></button> 142 i18n-content="extensionSettingsOptions" hidden></a>
144 <a class="options-link" 143 <a class="options-link"
145 i18n-content="extensionSettingsOptions" hidden></a> 144 i18n-content="extensionSettingsOptions" hidden></a>
146 <a class="site-link" target="_parent" hidden></a> 145 <a class="site-link" target="_parent" hidden></a>
147 <button class="launch-link link-button" 146 <a is="action-link" class="launch-link"
148 i18n-content="extensionSettingsLaunch" hidden></button> 147 i18n-content="extensionSettingsLaunch" hidden></a>
149 <button class="reload-link link-button" 148 <a is="action-link" class="reload-link"
aboxhall 2014/10/22 21:33:31 This seems like an action (i.e. button) rather tha
150 i18n-content="extensionSettingsReloadUnpacked" hidden> 149 i18n-content="extensionSettingsReloadUnpacked" hidden></a>
151 </button>
152 </div> 150 </div>
153 <div class="permanent-warnings"> 151 <div class="permanent-warnings">
154 <div class="extension-warnings" hidden> 152 <div class="extension-warnings" hidden>
155 <span i18n-content="extensionSettingsWarningsTitle"></span> 153 <span i18n-content="extensionSettingsWarningsTitle"></span>
156 <ul></ul> 154 <ul></ul>
157 </div> 155 </div>
158 <div class="suspicious-install-message" hidden> 156 <div class="suspicious-install-message" hidden>
159 <span i18n-content="extensionSettingsSuspiciousInstall"></span> 157 <span i18n-content="extensionSettingsSuspiciousInstall"></span>
160 <a target="_blank" class="learn-more-link" 158 <a target="_blank" class="learn-more-link"
161 i18n-values="href:extensionSettingsSuspiciousInstallHelpUrl" 159 i18n-values="href:extensionSettingsSuspiciousInstallHelpUrl"
162 i18n-content="extensionSettingsLearnMore" 160 i18n-content="extensionSettingsLearnMore"
163 href="#"> 161 href="#">
164 </a> 162 </a>
165 </div> 163 </div>
166 </div> 164 </div>
167 <div class="dependent-extensions-message" hidden> 165 <div class="dependent-extensions-message" hidden>
168 <span i18n-content="extensionSettingsDependentExtensions"></span> 166 <span i18n-content="extensionSettingsDependentExtensions"></span>
169 <ul></ul> 167 <ul></ul>
170 </div> 168 </div>
171 <div class="developer-extras"> 169 <div class="developer-extras">
172 <div> 170 <div>
173 <span i18n-content="extensionSettingsExtensionId"></span> 171 <span i18n-content="extensionSettingsExtensionId"></span>
174 <span class="extension-id"></span> 172 <span class="extension-id"></span>
175 </div> 173 </div>
176 <div class="load-path" hidden> 174 <div class="load-path" hidden>
177 <span i18n-content="extensionSettingsExtensionPath"></span> 175 <span i18n-content="extensionSettingsExtensionPath"></span>
178 <a href="#"></a> 176 <a is="action-link"></a>
179 </div> 177 </div>
180 <div class="managed-message" 178 <div class="managed-message"
181 i18n-content="extensionSettingsPolicyControlled" hidden> 179 i18n-content="extensionSettingsPolicyControlled" hidden>
182 </div> 180 </div>
183 <div class="active-views" hidden> 181 <div class="active-views" hidden>
184 <span i18n-content="extensionSettingsInspectViews"></span> 182 <span i18n-content="extensionSettingsInspectViews"></span>
185 <a href="#"></a> 183 <a is="action-link"></a>
186 </div> 184 </div>
187 <div class="manifest-errors" hidden></div> 185 <div class="manifest-errors" hidden></div>
188 <div class="runtime-errors" hidden></div> 186 <div class="runtime-errors" hidden></div>
189 <div class="install-warnings" hidden> 187 <div class="install-warnings" hidden>
190 <span i18n-content="extensionSettingsInstallWarnings"></span> 188 <span i18n-content="extensionSettingsInstallWarnings"></span>
191 <ul></ul> 189 <ul></ul>
192 </div> 190 </div>
193 </div> 191 </div>
194 <div class="optional-controls"> 192 <div class="optional-controls">
195 <button class="show-button" 193 <button class="show-button"
(...skipping 22 matching lines...) Expand all
218 <input type="checkbox"> 216 <input type="checkbox">
219 <span i18n-content="extensionSettingsAllowFileAccess"></span> 217 <span i18n-content="extensionSettingsAllowFileAccess"></span>
220 </label> 218 </label>
221 </div> 219 </div>
222 </div> 220 </div>
223 <div class="butter-bar" 221 <div class="butter-bar"
224 i18n-values=".innerHTML:extensionSettingsIncognitoWarning" hidden> 222 i18n-values=".innerHTML:extensionSettingsIncognitoWarning" hidden>
225 </div> 223 </div>
226 </div> 224 </div>
227 <div class="enable-controls"> 225 <div class="enable-controls">
228 <div class="terminated-reload-link link-button" 226 <a is="action-link" class="terminated-reload-link"
aboxhall 2014/10/22 21:33:31 Wow, this never made any sense at all...
Dan Beam 2014/10/23 03:05:44 yeah, these probably worked via mouse click only
aboxhall 2014/10/22 21:33:31 This seems like an action to me.
229 i18n-content="extensionSettingsReloadTerminated" hidden></div> 227 i18n-content="extensionSettingsReloadTerminated" hidden></a>
230 <div class="corrupted-repair-button link-button" 228 <a class="corrupted-repair-button"
aboxhall 2014/10/22 21:33:31 I can't figure out what this does...
Dan Beam 2014/10/23 03:05:44 Done. (added is="action-link")
231 i18n-content="extensionSettingsRepairCorrupted" hidden></div> 229 i18n-content="extensionSettingsRepairCorrupted" hidden></a>
232 <div class="checkbox enable-checkbox" hidden><label> 230 <div class="checkbox enable-checkbox" hidden><label>
233 <input type="checkbox"> 231 <input type="checkbox">
234 <span class="enable-checkbox-text"> 232 <span class="enable-checkbox-text">
235 <span class="enabled-text" i18n-content="extensionSettingsEnabled"> 233 <span class="enabled-text" i18n-content="extensionSettingsEnabled">
236 </span> 234 </span>
237 <span class="enable-text" i18n-content="extensionSettingsEnable"> 235 <span class="enable-text" i18n-content="extensionSettingsEnable">
238 </span> 236 </span>
239 </span> 237 </span>
240 </label> 238 </label>
241 <span class="location-text"></span> 239 <span class="location-text"></span>
(...skipping 16 matching lines...) Expand all
258 <include src="../../../../ui/webui/resources/html/trash.html"> 256 <include src="../../../../ui/webui/resources/html/trash.html">
259 <include src="extension_error.html"> 257 <include src="extension_error.html">
260 258
261 </div> 259 </div>
262 260
263 <script src="chrome://extensions-frame/strings.js"></script> 261 <script src="chrome://extensions-frame/strings.js"></script>
264 <script src="chrome://resources/js/i18n_template2.js"></script> 262 <script src="chrome://resources/js/i18n_template2.js"></script>
265 263
266 </body> 264 </body>
267 </html> 265 </html>
OLDNEW
« no previous file with comments | « chrome/browser/resources/extensions/extensions.css ('k') | chrome/browser/resources/extensions/extensions.js » ('j') | chrome/browser/resources/hotword_audio_verification/steps/audio_history_step.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698