Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6635032: Removing references to off the record in comments and log messages. (Closed)

Created:
9 years, 9 months ago by Vipul
Modified:
9 years, 7 months ago
Reviewers:
akalin
CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+cc_chromium.org, stuartmorgan+watch_chromium.org, jam, Erik does not do reviews, brettw-cc_chromium.org, kkania, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Removing references to off the record in comments and log messages. BUG=3333 TEST=None

Patch Set 1 #

Patch Set 2 : Correct one reference to 'incognito(incognito)' to 'incognito' #

Patch Set 3 : Add name to AUTHORS file. #

Patch Set 4 : Updating the AUTHORS file. Patch submitted by: Vipul Bhasin<vipul.bhasin@gmail.com> #

Total comments: 6

Patch Set 5 : Fix issues pointed out by code reviewer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -74 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/chrome_main_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/background_contents_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background_contents_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/authenticator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/google_authenticator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/new_user_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_base_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_base_provider.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/content_settings_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_cookies_unittest.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_webstore_private_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/io_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile.h View 6 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/base_session_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_restore_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_init.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_list.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_bar_state.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/browser_actions_container.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/options/content_exceptions_table_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/exceptions_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/visitedlink/visitedlink_master.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/plugin_channel.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/testing_profile.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ui_test_utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M net/ocsp/nss_ocsp.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
akalin
Few nits http://codereview.chromium.org/6635032/diff/1093/chrome/browser/autocomplete/search_provider.cc File chrome/browser/autocomplete/search_provider.cc (right): http://codereview.chromium.org/6635032/diff/1093/chrome/browser/autocomplete/search_provider.cc#newcode352 chrome/browser/autocomplete/search_provider.cc:352: // Don't run Suggest when incognito, the ...
9 years, 9 months ago (2011-03-08 03:07:46 UTC) #1
Vipul
new snapshot uploaded.
9 years, 9 months ago (2011-03-08 03:34:39 UTC) #2
akalin
LGTM I'll put it through the trybots in a separate patch, then will commit when ...
9 years, 9 months ago (2011-03-08 03:39:54 UTC) #3
akalin
On 2011/03/08 03:39:54, akalin wrote: > LGTM > > I'll put it through the trybots ...
9 years, 9 months ago (2011-03-08 04:13:20 UTC) #4
akalin
9 years, 9 months ago (2011-03-08 21:17:10 UTC) #5 
Committed in other patch.  Congrats!

Powered by Google App Engine
This is Rietveld 408576698