chrome/browser/geolocation/geolocation_browsertest.cc - Issue 6635032: Removing references to off the record in comments and log messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_browsertest.cc

Issue 6635032: Removing references to off the record in comments and log messages. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Fix issues pointed out by code reviewer Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/geolocation/geolocation_browsertest.cc

diff --git a/chrome/browser/geolocation/geolocation_browsertest.cc b/chrome/browser/geolocation/geolocation_browsertest.cc

index 4e831c21b1e07d0f7304fdb6cec65211008aac6e..9d26979e49a75e51d6bda5548baad4ea58c8443d 100644

--- a/chrome/browser/geolocation/geolocation_browsertest.cc

+++ b/chrome/browser/geolocation/geolocation_browsertest.cc

@@ -453,7 +453,7 @@ IN_PROC_BROWSER_TEST_F(GeolocationBrowserTest, NoInfobarForOffTheRecord) {

CheckGeoposition(MockLocationProvider::instance_->position_);

// Disables further prompts from this tab.

CheckStringValueFromJavascript("0", "geoSetMaxNavigateCount(0)");

- // Go off the record, and checks no infobar will be created.

+ // Go incognito, and checks no infobar will be created.

ASSERT_TRUE(Initialize(INITIALIZATION_OFFTHERECORD));

AddGeolocationWatch(false);

CheckGeoposition(MockLocationProvider::instance_->position_);

« no previous file with comments | « chrome/browser/extensions/extension_webstore_private_api.cc ('k') | chrome/browser/io_thread.cc » ('j') | no next file with comments »