chrome/browser/tab_contents/thumbnail_generator_unittest.cc - Issue 6635032: Removing references to off the record in comments and log messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/thumbnail_generator_unittest.cc

Issue 6635032: Removing references to off the record in comments and log messages. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Fix issues pointed out by code reviewer Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/tab_contents/thumbnail_generator_unittest.cc

diff --git a/chrome/browser/tab_contents/thumbnail_generator_unittest.cc b/chrome/browser/tab_contents/thumbnail_generator_unittest.cc

index ecc632a243b23f0e163f2396b84ec259a19caf9d..73747c1265fec530fff0824642965c83dc25a838 100644

--- a/chrome/browser/tab_contents/thumbnail_generator_unittest.cc

+++ b/chrome/browser/tab_contents/thumbnail_generator_unittest.cc

@@ -338,12 +338,12 @@ TEST(ThumbnailGeneratorSimpleTest, ShouldUpdateThumbnail) {

EXPECT_TRUE(ThumbnailGenerator::ShouldUpdateThumbnail(

&profile, top_sites.get(), kGoodURL));

- // Should be false, if it's in the off-the-record mode.

+ // Should be false, if it's in the incognito mode.

profile.set_off_the_record(true);

EXPECT_FALSE(ThumbnailGenerator::ShouldUpdateThumbnail(

&profile, top_sites.get(), kGoodURL));

- // Should be true again, once turning off the off-the-record mode.

+ // Should be true again, once turning off the incognito mode.

profile.set_off_the_record(false);

EXPECT_TRUE(ThumbnailGenerator::ShouldUpdateThumbnail(

&profile, top_sites.get(), kGoodURL));

« no previous file with comments | « chrome/browser/tab_contents/thumbnail_generator.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »