chrome/browser/content_settings/content_settings_pref_provider_unittest.cc - Issue 6635032: Removing references to off the record in comments and log messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

Issue 6635032: Removing references to off the record in comments and log messages. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Fix issues pointed out by code reviewer Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/content_settings_base_provider.cc ('k') | chrome/browser/content_settings/content_settings_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

diff --git a/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc b/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

index fda116deec9f47db0e70b2ef07b1757162385e08..6d223da310922c2b2cfa41c7ea68f10f480008db 100644

--- a/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

+++ b/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

@@ -107,7 +107,7 @@ TEST_F(PrefDefaultProviderTest, OffTheRecord) {

otr_provider.ProvideDefaultSetting(CONTENT_SETTINGS_TYPE_COOKIES));

// Changing content settings on the main provider should also affect the

- // off-the-record map.

+ // incognito map.

provider.UpdateDefaultSetting(CONTENT_SETTINGS_TYPE_COOKIES,

CONTENT_SETTING_BLOCK);

EXPECT_EQ(CONTENT_SETTING_BLOCK,

@@ -115,7 +115,7 @@ TEST_F(PrefDefaultProviderTest, OffTheRecord) {

EXPECT_EQ(CONTENT_SETTING_BLOCK,

otr_provider.ProvideDefaultSetting(CONTENT_SETTINGS_TYPE_COOKIES));

- // Changing content settings on the off-the-record provider should be ignored.

+ // Changing content settings on the incognito provider should be ignored.

otr_provider.UpdateDefaultSetting(CONTENT_SETTINGS_TYPE_COOKIES,

CONTENT_SETTING_ALLOW);

EXPECT_EQ(CONTENT_SETTING_BLOCK,