Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1074)

Side by Side Diff: chrome/browser/chromeos/login/login_utils.cc

Issue 6635032: Removing references to off the record in comments and log messages. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Updating the AUTHORS file. Patch submitted by: Vipul Bhasin<vipul.bhasin@gmail.com> Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/login/login_utils.h" 5 #include "chrome/browser/chromeos/login/login_utils.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/file_path.h" 10 #include "base/file_path.h"
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 111
112 // Invoked after the user has successfully logged in. This launches a browser 112 // Invoked after the user has successfully logged in. This launches a browser
113 // and does other bookkeeping after logging in. 113 // and does other bookkeeping after logging in.
114 virtual void CompleteLogin( 114 virtual void CompleteLogin(
115 const std::string& username, 115 const std::string& username,
116 const std::string& password, 116 const std::string& password,
117 const GaiaAuthConsumer::ClientLoginResult& credentials, 117 const GaiaAuthConsumer::ClientLoginResult& credentials,
118 bool pending_requests); 118 bool pending_requests);
119 119
120 // Invoked after the tmpfs is successfully mounted. 120 // Invoked after the tmpfs is successfully mounted.
121 // Launches a browser in the off the record (incognito) mode. 121 // Launches a browser in the incognito (incognito) mode.
akalin 2011/03/08 03:07:47 no need for " (incognito)"
122 virtual void CompleteOffTheRecordLogin(const GURL& start_url); 122 virtual void CompleteOffTheRecordLogin(const GURL& start_url);
123 123
124 // Invoked when the user is logging in for the first time, or is logging in as 124 // Invoked when the user is logging in for the first time, or is logging in as
125 // a guest user. 125 // a guest user.
126 virtual void SetFirstLoginPrefs(PrefService* prefs); 126 virtual void SetFirstLoginPrefs(PrefService* prefs);
127 127
128 // Creates and returns the authenticator to use. The caller owns the returned 128 // Creates and returns the authenticator to use. The caller owns the returned
129 // Authenticator and must delete it when done. 129 // Authenticator and must delete it when done.
130 virtual Authenticator* CreateAuthenticator(LoginStatusConsumer* consumer); 130 virtual Authenticator* CreateAuthenticator(LoginStatusConsumer* consumer);
131 131
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
378 // Here we don't enable keyboard layouts. Input methods are set up when 378 // Here we don't enable keyboard layouts. Input methods are set up when
379 // the user first logs in. Then the user may customize the input methods. 379 // the user first logs in. Then the user may customize the input methods.
380 // Hence changing input methods here, just because the user's UI language 380 // Hence changing input methods here, just because the user's UI language
381 // is different from the login screen UI language, is not desirable. Note 381 // is different from the login screen UI language, is not desirable. Note
382 // that input method preferences are synced, so users can use their 382 // that input method preferences are synced, so users can use their
383 // farovite input methods as soon as the preferences are synced. 383 // farovite input methods as soon as the preferences are synced.
384 LanguageSwitchMenu::SwitchLanguage(pref_locale); 384 LanguageSwitchMenu::SwitchLanguage(pref_locale);
385 } 385 }
386 386
387 void LoginUtilsImpl::CompleteOffTheRecordLogin(const GURL& start_url) { 387 void LoginUtilsImpl::CompleteOffTheRecordLogin(const GURL& start_url) {
388 VLOG(1) << "Completing off the record login"; 388 VLOG(1) << "Completing incognito login";
389 389
390 UserManager::Get()->OffTheRecordUserLoggedIn(); 390 UserManager::Get()->OffTheRecordUserLoggedIn();
391 391
392 if (CrosLibrary::Get()->EnsureLoaded()) { 392 if (CrosLibrary::Get()->EnsureLoaded()) {
393 // For guest session we ask session manager to restart Chrome with --bwsi 393 // For guest session we ask session manager to restart Chrome with --bwsi
394 // flag. We keep only some of the arguments of this process. 394 // flag. We keep only some of the arguments of this process.
395 const CommandLine& browser_command_line = *CommandLine::ForCurrentProcess(); 395 const CommandLine& browser_command_line = *CommandLine::ForCurrentProcess();
396 CommandLine command_line(browser_command_line.GetProgram()); 396 CommandLine command_line(browser_command_line.GetProgram());
397 std::string cmd_line_str = 397 std::string cmd_line_str =
398 GetOffTheRecordCommandLine(start_url, 398 GetOffTheRecordCommandLine(start_url,
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
585 BrowserInit browser_init; 585 BrowserInit browser_init;
586 int return_code; 586 int return_code;
587 browser_init.LaunchBrowser(*CommandLine::ForCurrentProcess(), 587 browser_init.LaunchBrowser(*CommandLine::ForCurrentProcess(),
588 profile, 588 profile,
589 FilePath(), 589 FilePath(),
590 true, 590 true,
591 &return_code); 591 &return_code);
592 } 592 }
593 593
594 } // namespace chromeos 594 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698