chrome/browser/notifications/desktop_notification_service.cc - Issue 6635032: Removing references to off the record in comments and log messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/desktop_notification_service.cc

Issue 6635032: Removing references to off the record in comments and log messages. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Fix issues pointed out by code reviewer Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/notifications/desktop_notification_service.cc

diff --git a/chrome/browser/notifications/desktop_notification_service.cc b/chrome/browser/notifications/desktop_notification_service.cc

index 90c0cbb854d399d2afd3d8f503e5cf27b82774ef..76cb3452bbaf0c5db659531e7b16b614d75c03ad 100644

--- a/chrome/browser/notifications/desktop_notification_service.cc

+++ b/chrome/browser/notifications/desktop_notification_service.cc

@@ -411,7 +411,7 @@ void DesktopNotificationService::OnPrefsChanged(const std::string& pref_name) {

void DesktopNotificationService::PersistPermissionChange(

const GURL& origin, bool is_allowed) {

- // Don't persist changes when off the record.

+ // Don't persist changes when incognito.

if (profile_->IsOffTheRecord())

return;

« no previous file with comments | « chrome/browser/metrics/metrics_service.cc ('k') | chrome/browser/profiles/profile.h » ('j') | no next file with comments »