Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 663363002: Standardize usage of virtual/override/final in gpu/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final in gpu/ This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. The generator for the GLES2 command buffers has also been updated. BUG=417463 TBR=piman@chromium.org Committed: https://crrev.com/1f4d1d7fb990754e14b53dd67dccdeb6b98ef719 Cr-Commit-Position: refs/heads/master@{#300496}

Patch Set 1 #

Patch Set 2 : Update generator script #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2123 lines, -2331 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 4 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/buffer_tracker_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/client_test_helper.h View 1 chunk +15 lines, -15 lines 0 comments Download
M gpu/command_buffer/client/cmd_buffer_helper_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/gl_in_process_context.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 3 chunks +18 lines, -21 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 chunk +491 lines, -529 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 1 chunk +17 lines, -19 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 chunk +466 lines, -508 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 chunk +466 lines, -508 lines 0 comments Download
M gpu/command_buffer/client/program_info_manager.cc View 2 chunks +72 lines, -73 lines 0 comments Download
M gpu/command_buffer/client/share_group.cc View 9 chunks +33 lines, -30 lines 0 comments Download
M gpu/command_buffer/client/transfer_buffer.h View 1 chunk +16 lines, -18 lines 0 comments Download
M gpu/command_buffer/common/buffer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager.h View 2 chunks +3 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_idle.h View 2 chunks +9 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_idle.cc View 1 chunk +8 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_share_group.h View 2 chunks +9 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_share_group.cc View 3 chunks +10 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_stub.h View 1 chunk +9 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_stub.cc View 1 chunk +8 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_sync.h View 2 chunks +9 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_sync.cc View 1 chunk +8 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/command_buffer_service.h View 1 chunk +15 lines, -16 lines 0 comments Download
M gpu/command_buffer/service/common_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/common_decoder_unittest.cc View 4 chunks +9 lines, -15 lines 0 comments Download
M gpu/command_buffer/service/error_state.cc View 1 chunk +38 lines, -39 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.cc View 9 chunks +47 lines, -77 lines 0 comments Download
M gpu/command_buffer/service/gl_context_virtual.h View 1 chunk +14 lines, -15 lines 0 comments Download
M gpu/command_buffer/service/gl_state_restorer_impl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 7 chunks +81 lines, -96 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 chunk +6 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler.h View 2 chunks +6 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gpu_state_tracer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gpu_tracer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gpu_tracer_unittest.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.h View 2 chunks +30 lines, -31 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/memory_program_cache.h View 2 chunks +11 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/program_cache_unittest.cc View 2 chunks +10 lines, -11 lines 0 comments Download
M gpu/command_buffer/service/query_manager.cc View 9 chunks +37 lines, -37 lines 0 comments Download
M gpu/command_buffer/service/query_manager_unittest.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/shader_translator.h View 2 chunks +14 lines, -16 lines 0 comments Download
M gpu/command_buffer/service/shader_translator_cache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/texture_definition.cc View 2 chunks +24 lines, -24 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/transfer_buffer_manager.h View 1 chunk +6 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/transfer_buffer_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.h View 2 chunks +19 lines, -20 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M gpu/config/gpu_blacklist.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_driver_bug_list.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_test_config.h View 2 chunks +3 lines, -3 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.h View 2 chunks +19 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dcheng
6 years, 2 months ago (2014-10-21 10:55:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663363002/20001
6 years, 2 months ago (2014-10-21 10:57:27 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/27566)
6 years, 2 months ago (2014-10-21 12:56:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663363002/20001
6 years, 2 months ago (2014-10-21 15:44:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-21 16:22:15 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 16:22:50 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f4d1d7fb990754e14b53dd67dccdeb6b98ef719
Cr-Commit-Position: refs/heads/master@{#300496}

Powered by Google App Engine
This is Rietveld 408576698