Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: gpu/command_buffer/service/common_decoder_unittest.cc

Issue 663363002: Standardize usage of virtual/override/final in gpu/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update generator script Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gpu/command_buffer/service/common_decoder.h ('k') | gpu/command_buffer/service/error_state.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/common_decoder.h" 5 #include "gpu/command_buffer/service/common_decoder.h"
6 #include "gpu/command_buffer/service/cmd_buffer_engine.h" 6 #include "gpu/command_buffer/service/cmd_buffer_engine.h"
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 namespace gpu { 9 namespace gpu {
10 10
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 EXPECT_EQ(0, memcmp(data, bucket.GetData(0, sizeof(data)), sizeof(data))); 44 EXPECT_EQ(0, memcmp(data, bucket.GetData(0, sizeof(data)), sizeof(data)));
45 EXPECT_TRUE(bucket.SetData(data, 2, sizeof(data))); 45 EXPECT_TRUE(bucket.SetData(data, 2, sizeof(data)));
46 EXPECT_EQ(0, memcmp(data, bucket.GetData(2, sizeof(data)), sizeof(data))); 46 EXPECT_EQ(0, memcmp(data, bucket.GetData(2, sizeof(data)), sizeof(data)));
47 EXPECT_FALSE(bucket.SetData(data, 0, sizeof(data) * 2)); 47 EXPECT_FALSE(bucket.SetData(data, 0, sizeof(data) * 2));
48 EXPECT_FALSE(bucket.SetData(data, 5, sizeof(data))); 48 EXPECT_FALSE(bucket.SetData(data, 5, sizeof(data)));
49 } 49 }
50 50
51 class TestCommonDecoder : public CommonDecoder { 51 class TestCommonDecoder : public CommonDecoder {
52 public: 52 public:
53 // Overridden from AsyncAPIInterface 53 // Overridden from AsyncAPIInterface
54 virtual const char* GetCommandName(unsigned int command_id) const override { 54 const char* GetCommandName(unsigned int command_id) const override {
55 return GetCommonCommandName(static_cast<cmd::CommandId>(command_id)); 55 return GetCommonCommandName(static_cast<cmd::CommandId>(command_id));
56 } 56 }
57 57
58 // Overridden from AsyncAPIInterface 58 // Overridden from AsyncAPIInterface
59 virtual error::Error DoCommand( 59 error::Error DoCommand(unsigned int command,
60 unsigned int command, 60 unsigned int arg_count,
61 unsigned int arg_count, 61 const void* cmd_data) override {
62 const void* cmd_data) override {
63 return DoCommonCommand(command, arg_count, cmd_data); 62 return DoCommonCommand(command, arg_count, cmd_data);
64 } 63 }
65 64
66 CommonDecoder::Bucket* GetBucket(uint32 id) const { 65 CommonDecoder::Bucket* GetBucket(uint32 id) const {
67 return CommonDecoder::GetBucket(id); 66 return CommonDecoder::GetBucket(id);
68 } 67 }
69 }; 68 };
70 69
71 class MockCommandBufferEngine : public CommandBufferEngine { 70 class MockCommandBufferEngine : public CommandBufferEngine {
72 public: 71 public:
73 static const int32 kStartValidShmId = 1; 72 static const int32 kStartValidShmId = 1;
74 static const int32 kValidShmId = 2; 73 static const int32 kValidShmId = 2;
75 static const int32 kInvalidShmId = 3; 74 static const int32 kInvalidShmId = 3;
76 static const size_t kBufferSize = 1024; 75 static const size_t kBufferSize = 1024;
77 static const int32 kValidOffset = kBufferSize / 2; 76 static const int32 kValidOffset = kBufferSize / 2;
78 static const int32 kInvalidOffset = kBufferSize; 77 static const int32 kInvalidOffset = kBufferSize;
79 78
80 MockCommandBufferEngine() 79 MockCommandBufferEngine()
81 : CommandBufferEngine(), 80 : CommandBufferEngine(),
82 token_(), 81 token_(),
83 get_offset_(0) { 82 get_offset_(0) {
84 scoped_ptr<base::SharedMemory> shared_memory(new base::SharedMemory()); 83 scoped_ptr<base::SharedMemory> shared_memory(new base::SharedMemory());
85 shared_memory->CreateAndMapAnonymous(kBufferSize); 84 shared_memory->CreateAndMapAnonymous(kBufferSize);
86 buffer_ = MakeBufferFromSharedMemory(shared_memory.Pass(), kBufferSize); 85 buffer_ = MakeBufferFromSharedMemory(shared_memory.Pass(), kBufferSize);
87 } 86 }
88 87
89 // Overridden from CommandBufferEngine. 88 // Overridden from CommandBufferEngine.
90 virtual scoped_refptr<gpu::Buffer> GetSharedMemoryBuffer(int32 shm_id) 89 scoped_refptr<gpu::Buffer> GetSharedMemoryBuffer(int32 shm_id) override {
91 override {
92 if (IsValidSharedMemoryId(shm_id)) 90 if (IsValidSharedMemoryId(shm_id))
93 return buffer_; 91 return buffer_;
94 return NULL; 92 return NULL;
95 } 93 }
96 94
97 template <typename T> 95 template <typename T>
98 T GetSharedMemoryAs(uint32 offset) { 96 T GetSharedMemoryAs(uint32 offset) {
99 DCHECK_LT(offset, kBufferSize); 97 DCHECK_LT(offset, kBufferSize);
100 int8* buffer_memory = static_cast<int8*>(buffer_->memory()); 98 int8* buffer_memory = static_cast<int8*>(buffer_->memory());
101 return reinterpret_cast<T>(&buffer_memory[offset]); 99 return reinterpret_cast<T>(&buffer_memory[offset]);
102 } 100 }
103 101
104 int32 GetSharedMemoryOffset(const void* memory) { 102 int32 GetSharedMemoryOffset(const void* memory) {
105 int8* buffer_memory = static_cast<int8*>(buffer_->memory()); 103 int8* buffer_memory = static_cast<int8*>(buffer_->memory());
106 ptrdiff_t offset = static_cast<const int8*>(memory) - &buffer_memory[0]; 104 ptrdiff_t offset = static_cast<const int8*>(memory) - &buffer_memory[0];
107 DCHECK_GE(offset, 0); 105 DCHECK_GE(offset, 0);
108 DCHECK_LT(static_cast<size_t>(offset), kBufferSize); 106 DCHECK_LT(static_cast<size_t>(offset), kBufferSize);
109 return static_cast<int32>(offset); 107 return static_cast<int32>(offset);
110 } 108 }
111 109
112 // Overridden from CommandBufferEngine. 110 // Overridden from CommandBufferEngine.
113 virtual void set_token(int32 token) override { 111 void set_token(int32 token) override { token_ = token; }
114 token_ = token;
115 }
116 112
117 int32 token() const { 113 int32 token() const {
118 return token_; 114 return token_;
119 } 115 }
120 116
121 // Overridden from CommandBufferEngine. 117 // Overridden from CommandBufferEngine.
122 virtual bool SetGetBuffer(int32 transfer_buffer_id) override { 118 bool SetGetBuffer(int32 transfer_buffer_id) override {
123 NOTREACHED(); 119 NOTREACHED();
124 return false; 120 return false;
125 } 121 }
126 122
127 // Overridden from CommandBufferEngine. 123 // Overridden from CommandBufferEngine.
128 virtual bool SetGetOffset(int32 offset) override { 124 bool SetGetOffset(int32 offset) override {
129 if (static_cast<size_t>(offset) < kBufferSize) { 125 if (static_cast<size_t>(offset) < kBufferSize) {
130 get_offset_ = offset; 126 get_offset_ = offset;
131 return true; 127 return true;
132 } 128 }
133 return false; 129 return false;
134 } 130 }
135 131
136 // Overridden from CommandBufferEngine. 132 // Overridden from CommandBufferEngine.
137 virtual int32 GetGetOffset() override { 133 int32 GetGetOffset() override { return get_offset_; }
138 return get_offset_;
139 }
140 134
141 private: 135 private:
142 bool IsValidSharedMemoryId(int32 shm_id) { 136 bool IsValidSharedMemoryId(int32 shm_id) {
143 return shm_id == kValidShmId || shm_id == kStartValidShmId; 137 return shm_id == kValidShmId || shm_id == kStartValidShmId;
144 } 138 }
145 139
146 scoped_refptr<gpu::Buffer> buffer_; 140 scoped_refptr<gpu::Buffer> buffer_;
147 int32 token_; 141 int32 token_;
148 int32 get_offset_; 142 int32 get_offset_;
149 }; 143 };
(...skipping 354 matching lines...) Expand 10 before | Expand all | Expand 10 after
504 MockCommandBufferEngine::kValidShmId, kSomeOffsetInSharedMemory); 498 MockCommandBufferEngine::kValidShmId, kSomeOffsetInSharedMemory);
505 EXPECT_NE(error::kNoError, ExecuteCmd(cmd)); 499 EXPECT_NE(error::kNoError, ExecuteCmd(cmd));
506 500
507 // Check that it fails if the size is invalid 501 // Check that it fails if the size is invalid
508 cmd.Init(kBucketId, 0, sizeof(kData) + 1, 502 cmd.Init(kBucketId, 0, sizeof(kData) + 1,
509 MockCommandBufferEngine::kValidShmId, kSomeOffsetInSharedMemory); 503 MockCommandBufferEngine::kValidShmId, kSomeOffsetInSharedMemory);
510 EXPECT_NE(error::kNoError, ExecuteCmd(cmd)); 504 EXPECT_NE(error::kNoError, ExecuteCmd(cmd));
511 } 505 }
512 506
513 } // namespace gpu 507 } // namespace gpu
OLDNEW
« no previous file with comments | « gpu/command_buffer/service/common_decoder.h ('k') | gpu/command_buffer/service/error_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698