gpu/command_buffer/service/shader_translator_cache.h - Issue 663363002: Standardize usage of virtual/override/final in gpu/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/shader_translator_cache.h

Issue 663363002: Standardize usage of virtual/override/final in gpu/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update generator script Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/shader_translator_cache.h

diff --git a/gpu/command_buffer/service/shader_translator_cache.h b/gpu/command_buffer/service/shader_translator_cache.h

index 02f58293c55dba95cb3e98671315211470671264..e804ef26b8c3ade1774373d2a21c85a4ddbd15f0 100644

--- a/gpu/command_buffer/service/shader_translator_cache.h

+++ b/gpu/command_buffer/service/shader_translator_cache.h

@@ -29,7 +29,7 @@ class GPU_EXPORT ShaderTranslatorCache

ShaderTranslatorCache();

// ShaderTranslator::DestructionObserver implementation

- virtual void OnDestruct(ShaderTranslator* translator) override;

+ void OnDestruct(ShaderTranslator* translator) override;

scoped_refptr<ShaderTranslator> GetTranslator(

sh::GLenum shader_type,

@@ -41,7 +41,7 @@ class GPU_EXPORT ShaderTranslatorCache

private:

friend class base::RefCounted<ShaderTranslatorCache>;

- virtual ~ShaderTranslatorCache();

+ ~ShaderTranslatorCache() override;

// Parameters passed into ShaderTranslator::Init

struct ShaderTranslatorInitParams {