Issue 663323002: Standardize usage of virtual/override/final in chrome/browser/component_updater/

Issue 663323002: Standardize usage of virtual/override/final in chrome/browser/component_updater/ (Closed)

Created:
6 years, 2 months ago by dcheng

Modified:
6 years, 2 months ago

Reviewers:
Sorin Jianu

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Standardize usage of virtual/override/final in chrome/browser/component_updater/ BUG=417463 TBR=sorin@chromium.org Committed: https://crrev.com/bb4c62a71e75520ab122e3bf9acfb23195b43e0b Cr-Commit-Position: refs/heads/master@{#300443}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -103 lines)			Patch
M	chrome/browser/component_updater/chrome_component_updater_configurator.cc	View	1	1 chunk	+22 lines, -23 lines	0 comments	Download
M	chrome/browser/component_updater/cld_component_installer.h	View	1	2 chunks	+12 lines, -14 lines	0 comments	Download
M	chrome/browser/component_updater/component_patcher_operation_out_of_process.h	View	1	1 chunk	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/component_updater/component_patcher_operation_out_of_process.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/component_updater/component_updater_resource_throttle.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/component_updater/ev_whitelist_component_installer.h	View	1	1 chunk	+12 lines, -14 lines	0 comments	Download
M	chrome/browser/component_updater/pepper_flash_component_installer.cc	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/component_updater/pnacl/pnacl_component_installer.h	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/component_updater/recovery_component_installer.cc	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/component_updater/swiftshader_component_installer.cc	View	1	2 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/component_updater/test/component_updater_service_unittest.cc	View	1	3 chunks	+13 lines, -13 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663323002/20001

6 years, 2 months ago (2014-10-21 09:28:17 UTC) #3

commit-bot: I haz the power

6 years, 2 months ago (2014-10-21 10:27:21 UTC) #5

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/bb4c62a71e75520ab122e3bf9acfb23195b43e0b
Cr-Commit-Position: refs/heads/master@{#300443}