chrome/browser/component_updater/component_patcher_operation_out_of_process.cc - Issue 663323002: Standardize usage of virtual/override/final in chrome/browser/component_updater/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/component_patcher_operation_out_of_process.cc

Issue 663323002: Standardize usage of virtual/override/final in chrome/browser/component_updater/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: formatted Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/component_patcher_operation_out_of_process.h ('k') | chrome/browser/component_updater/component_updater_resource_throttle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/component_patcher_operation_out_of_process.cc

diff --git a/chrome/browser/component_updater/component_patcher_operation_out_of_process.cc b/chrome/browser/component_updater/component_patcher_operation_out_of_process.cc

index 80e8c3f38c73ca12c1dae419a96eb06cb3021c4c..1a8285cb110b6711928a0598916c70f1a8c1e029 100644

--- a/chrome/browser/component_updater/component_patcher_operation_out_of_process.cc

+++ b/chrome/browser/component_updater/component_patcher_operation_out_of_process.cc

@@ -28,14 +28,14 @@ class PatchHost : public content::UtilityProcessHostClient {

void StartProcess(scoped_ptr<IPC::Message> message);

private:

- virtual ~PatchHost();

+ ~PatchHost() override;

void OnPatchFinished(int result);

// Overrides of content::UtilityProcessHostClient.

- virtual bool OnMessageReceived(const IPC::Message& message) override;

+ bool OnMessageReceived(const IPC::Message& message) override;

- virtual void OnProcessCrashed(int exit_code) override;

+ void OnProcessCrashed(int exit_code) override;

base::Callback<void(int result)> callback_;

scoped_refptr<base::SequencedTaskRunner> task_runner_;