chrome/browser/component_updater/component_updater_resource_throttle.cc - Issue 663323002: Standardize usage of virtual/override/final in chrome/browser/component_updater/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/component_updater_resource_throttle.cc

Issue 663323002: Standardize usage of virtual/override/final in chrome/browser/component_updater/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: formatted Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/component_patcher_operation_out_of_process.cc ('k') | chrome/browser/component_updater/ev_whitelist_component_installer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/component_updater_resource_throttle.cc

diff --git a/chrome/browser/component_updater/component_updater_resource_throttle.cc b/chrome/browser/component_updater/component_updater_resource_throttle.cc

index 53b8c790a34f556ba613e5b7c9e345958e440d6a..a18041991dd9087e20b0ec1bad9946691595ebfd 100644

--- a/chrome/browser/component_updater/component_updater_resource_throttle.cc

+++ b/chrome/browser/component_updater/component_updater_resource_throttle.cc

@@ -28,12 +28,12 @@ class CUResourceThrottle : public content::ResourceThrottle,

public base::SupportsWeakPtr<CUResourceThrottle> {

public:

CUResourceThrottle();

- virtual ~CUResourceThrottle();

+ ~CUResourceThrottle() override;

// Overriden from ResourceThrottle.

- virtual void WillStartRequest(bool* defer) override;

- virtual void WillRedirectRequest(const GURL& new_url, bool* defer) override;

- virtual const char* GetNameForLogging() const override;

+ void WillStartRequest(bool* defer) override;

+ void WillRedirectRequest(const GURL& new_url, bool* defer) override;

+ const char* GetNameForLogging() const override;

// Component updater calls this function via PostTask to unblock the request.

void Unblock();