chrome/browser/component_updater/swiftshader_component_installer.cc - Issue 663323002: Standardize usage of virtual/override/final in chrome/browser/component_updater/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/swiftshader_component_installer.cc

Issue 663323002: Standardize usage of virtual/override/final in chrome/browser/component_updater/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: formatted Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/recovery_component_installer.cc ('k') | chrome/browser/component_updater/test/component_updater_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/swiftshader_component_installer.cc

diff --git a/chrome/browser/component_updater/swiftshader_component_installer.cc b/chrome/browser/component_updater/swiftshader_component_installer.cc

index cd00273d7d1b7a12774d15aa8694a30a0472e77e..e92fd0f18be9c18d717af8837224eb9378a41e0f 100644

--- a/chrome/browser/component_updater/swiftshader_component_installer.cc

+++ b/chrome/browser/component_updater/swiftshader_component_installer.cc

@@ -99,15 +99,15 @@ class SwiftShaderComponentInstaller : public ComponentInstaller {

public:

explicit SwiftShaderComponentInstaller(const Version& version);

- virtual ~SwiftShaderComponentInstaller() {}

+ ~SwiftShaderComponentInstaller() override {}

- virtual void OnUpdateError(int error) override;

+ void OnUpdateError(int error) override;

- virtual bool Install(const base::DictionaryValue& manifest,

- const base::FilePath& unpack_path) override;

+ bool Install(const base::DictionaryValue& manifest,

+ const base::FilePath& unpack_path) override;

- virtual bool GetInstalledFile(const std::string& file,

- base::FilePath* installed_file) override;

+ bool GetInstalledFile(const std::string& file,

+ base::FilePath* installed_file) override;

private:

Version current_version_;

@@ -179,7 +179,7 @@ class UpdateChecker : public content::GpuDataManagerObserver {

public:

explicit UpdateChecker(ComponentUpdateService* cus);

- virtual void OnGpuInfoUpdate() override;

+ void OnGpuInfoUpdate() override;

private:

ComponentUpdateService* cus_;