Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: chrome/browser/component_updater/cld_component_installer.h

Issue 663323002: Standardize usage of virtual/override/final in chrome/browser/component_updater/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: formatted Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/cld_component_installer.h
diff --git a/chrome/browser/component_updater/cld_component_installer.h b/chrome/browser/component_updater/cld_component_installer.h
index 0979923c4bb4441f0ce7e7770f86c4f2b2b88380..0e913cc0ab0c0613aa95d1ca14efd7bce6e080de 100644
--- a/chrome/browser/component_updater/cld_component_installer.h
+++ b/chrome/browser/component_updater/cld_component_installer.h
@@ -26,7 +26,7 @@ class ComponentUpdateService;
class CldComponentInstallerTraits : public ComponentInstallerTraits {
public:
CldComponentInstallerTraits();
- virtual ~CldComponentInstallerTraits() {}
+ ~CldComponentInstallerTraits() override {}
private:
friend class CldComponentInstallerTest; // For access within SetUp()
@@ -41,19 +41,17 @@ class CldComponentInstallerTraits : public ComponentInstallerTraits {
FRIEND_TEST_ALL_PREFIXES(CldComponentInstallerTest, VerifyInstallation);
// The following methods override ComponentInstallerTraits.
- virtual bool CanAutoUpdate() const override;
- virtual bool OnCustomInstall(const base::DictionaryValue& manifest,
- const base::FilePath& install_dir) override;
- virtual bool VerifyInstallation(
- const base::DictionaryValue& manifest,
- const base::FilePath& install_dir) const override;
- virtual void ComponentReady(
- const base::Version& version,
- const base::FilePath& path,
- scoped_ptr<base::DictionaryValue> manifest) override;
- virtual base::FilePath GetBaseDirectory() const override;
- virtual void GetHash(std::vector<uint8_t>* hash) const override;
- virtual std::string GetName() const override;
+ bool CanAutoUpdate() const override;
+ bool OnCustomInstall(const base::DictionaryValue& manifest,
+ const base::FilePath& install_dir) override;
+ bool VerifyInstallation(const base::DictionaryValue& manifest,
+ const base::FilePath& install_dir) const override;
+ void ComponentReady(const base::Version& version,
+ const base::FilePath& path,
+ scoped_ptr<base::DictionaryValue> manifest) override;
+ base::FilePath GetBaseDirectory() const override;
+ void GetHash(std::vector<uint8_t>* hash) const override;
+ std::string GetName() const override;
static base::FilePath GetInstalledPath(const base::FilePath& base);

Powered by Google App Engine
This is Rietveld 408576698